Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: tools/testing/dart/multitest.dart

Issue 150223002: Add 'static type error' tags to multitests. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Rename 'static type error' to 'checked mode compile-time error'. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/language/map_literal1_test.dart ('k') | tools/testing/dart/test_progress.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/multitest.dart
diff --git a/tools/testing/dart/multitest.dart b/tools/testing/dart/multitest.dart
index 5541564062142ed1193366bb11516119dedd0c98..c5e80325ddc157ea3946aa49802caa5d24d5f0b6 100644
--- a/tools/testing/dart/multitest.dart
+++ b/tools/testing/dart/multitest.dart
@@ -78,7 +78,8 @@ void ExtractTestsFromMultitest(Path filePath,
contents = null;
Set<String> validMultitestOutcomes = new Set<String>.from(
['ok', 'compile-time error', 'runtime error',
- 'static type warning', 'dynamic type error']);
+ 'static type warning', 'dynamic type error',
+ 'checked mode compile-time error']);
List<String> testTemplate = new List<String>();
testTemplate.add(
@@ -241,10 +242,12 @@ Future doMultitest(Path filePath, String outputDir, Path suiteDir,
bool hasRuntimeErrors = outcome.contains('runtime error');
bool hasCompileError = outcome.contains('compile-time error');
bool isNegativeIfChecked = outcome.contains('dynamic type error');
+ bool hasCompileErrorIfChecked = outcome.contains('checked mode compile-time error');
doTest(multitestFilename,
hasCompileError,
hasRuntimeErrors,
isNegativeIfChecked: isNegativeIfChecked,
+ hasCompileErrorIfChecked: hasCompileErrorIfChecked,
hasStaticWarning: hasStaticWarning,
multitestOutcome: outcome,
multitestKey: key,
« no previous file with comments | « tests/language/map_literal1_test.dart ('k') | tools/testing/dart/test_progress.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698