Chromium Code Reviews
DescriptionRevert of validate uniform block index (patchset #2 id:40001 of https://codereview.chromium.org/1495113004/ )
Reason for revert:
Fails the WebGL 2 CTS:
http://build.chromium.org/p/chromium.gpu.fyi/builders/Mac%2010.9%20Release%20%28Intel%29/builds/25545
http://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Debug%20%28NVIDIA%29/builds/24371
http://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Release%20%28Intel%29/builds/14923
WebglConformance.conformance2_state_gl_enum_tests:
Failure: getError expected: INVALID_ENUM. Was INVALID_VALUE : gl.getActiveUniformBlockParameter(program, 0, desktopGL['UNIFORM_BLOCK_NAME_LENGTH']) should return INVALID_ENUM.
Original issue's description:
> validate uniform block index.
>
> should generate INVALID_VALUE when index >= the value of ACTIVE_UNIFORM_BLOCK.
>
> BUG=565347
>
> TEST=deqp/functional/gles3/negativestateapi.html
>
> Committed: https://crrev.com/68aa7b244494083167fbd3b62ab7315f1c1c242d
> Cr-Commit-Position: refs/heads/master@{#363471}
TBR=kbr@chromium.org,zmo@chromium.org,bajones@chromium.org,qiankun.miao@intel.com,yunchao.he@intel.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=565347
Committed: https://crrev.com/a821ff3470098c9e18acb4319fac22dea921d8f1
Cr-Commit-Position: refs/heads/master@{#363495}
Patch Set 1 #
Messages
Total messages: 7 (2 generated)
|
||||||||||||||||||||||||||||