Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issue 1502143004: Revert of validate uniform block index (Closed)

Created:
5 years ago by Jamie Madill
Modified:
5 years ago
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of validate uniform block index (patchset #2 id:40001 of https://codereview.chromium.org/1495113004/ ) Reason for revert: Fails the WebGL 2 CTS: http://build.chromium.org/p/chromium.gpu.fyi/builders/Mac%2010.9%20Release%20%28Intel%29/builds/25545 http://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Debug%20%28NVIDIA%29/builds/24371 http://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Release%20%28Intel%29/builds/14923 WebglConformance.conformance2_state_gl_enum_tests: Failure: getError expected: INVALID_ENUM. Was INVALID_VALUE : gl.getActiveUniformBlockParameter(program, 0, desktopGL['UNIFORM_BLOCK_NAME_LENGTH']) should return INVALID_ENUM. Original issue's description: > validate uniform block index. > > should generate INVALID_VALUE when index >= the value of ACTIVE_UNIFORM_BLOCK. > > BUG=565347 > > TEST=deqp/functional/gles3/negativestateapi.html > > Committed: https://crrev.com/68aa7b244494083167fbd3b62ab7315f1c1c242d > Cr-Commit-Position: refs/heads/master@{#363471} TBR=kbr@chromium.org,zmo@chromium.org,bajones@chromium.org,qiankun.miao@intel.com,yunchao.he@intel.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=565347 Committed: https://crrev.com/a821ff3470098c9e18acb4319fac22dea921d8f1 Cr-Commit-Position: refs/heads/master@{#363495}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -22 lines) Patch
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp View 3 chunks +0 lines, -20 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jamie Madill
Created Revert of validate uniform block index
5 years ago (2015-12-07 16:24:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1502143004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1502143004/1
5 years ago (2015-12-07 16:25:22 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-07 16:27:35 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a821ff3470098c9e18acb4319fac22dea921d8f1 Cr-Commit-Position: refs/heads/master@{#363495}
5 years ago (2015-12-07 16:29:23 UTC) #6
Zhenyao Mo
5 years ago (2015-12-22 21:54:09 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1547783002/ by zmo@chromium.org.

The reason for reverting is: revert the revert = reland
after webgl conformance tests have been rolled..

Powered by Google App Engine
This is Rietveld 408576698