Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issue 1502023002: Revert of Switch wtf/SpinLock to std::atomic (Closed)

Created:
5 years ago by jschuh
Modified:
5 years ago
CC:
Mads Ager (chromium), blink-reviews, blink-reviews-wtf_chromium.org, chromium-reviews, kouhei+heap_chromium.org, Mikhail, oilpan-reviews, dvyukov
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Switch wtf/SpinLock to std::atomic (patchset #9 id:190001 of https://codereview.chromium.org/1463683002/ ) Reason for revert: Tree is closed (Automatic: "compile" on http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Builder/builds/19077 "Linux Chromium OS ASan LSan Builder" from 5e58730d6fe40ef7cead75954ef5b1c05dea6d4b : jschuh ) Original issue's description: > Switch wtf/SpinLock to std::atomic > > Tsan identified a racy read in the existing spin lock loop. > Tsan is correct in the absolute sense, even though the read is > safe in practice. However, the architectures we support might > change, or the behavior of the compiler might change, so the > the best fix is to just use the proper std::atomic type, > because that is guaranteed to always be safe. And the compiled > code should be effectively unchanged. > > BUG=556469 > NOTRY=True > > Committed: https://crrev.com/5e58730d6fe40ef7cead75954ef5b1c05dea6d4b > Cr-Commit-Position: refs/heads/master@{#363347} TBR=esprehn@chromium.org,glider@chromium.org,haraken@chromium.org,yutak@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=556469 Committed: https://crrev.com/df707658fcdb00877c97b66bd473b9117ff57b15 Cr-Commit-Position: refs/heads/master@{#363348}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -99 lines) Patch
M third_party/WebKit/Source/web/tests/SpinLockTest.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/AddressSpaceRandomization.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/PartitionAlloc.h View 4 chunks +14 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/wtf/PartitionAlloc.cpp View 9 chunks +39 lines, -35 lines 0 comments Download
M third_party/WebKit/Source/wtf/Partitions.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/Partitions.cpp View 4 chunks +7 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/wtf/SpinLock.h View 1 chunk +22 lines, -34 lines 0 comments Download
M third_party/WebKit/Source/wtf/SpinLock.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/TextEncodingRegistry.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
jschuh
Created Revert of Switch wtf/SpinLock to std::atomic
5 years ago (2015-12-05 22:49:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1502023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1502023002/1
5 years ago (2015-12-05 22:49:39 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-05 22:50:45 UTC) #4
commit-bot: I haz the power
5 years ago (2015-12-05 22:51:32 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/df707658fcdb00877c97b66bd473b9117ff57b15
Cr-Commit-Position: refs/heads/master@{#363348}

Powered by Google App Engine
This is Rietveld 408576698