DescriptionRevert of Switch wtf/SpinLock to std::atomic (patchset #9 id:190001 of https://codereview.chromium.org/1463683002/ )
Reason for revert:
Tree is closed (Automatic: "compile" on http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Builder/builds/19077 "Linux Chromium OS ASan LSan Builder" from 5e58730d6fe40ef7cead75954ef5b1c05dea6d4b : jschuh )
Original issue's description:
> Switch wtf/SpinLock to std::atomic
>
> Tsan identified a racy read in the existing spin lock loop.
> Tsan is correct in the absolute sense, even though the read is
> safe in practice. However, the architectures we support might
> change, or the behavior of the compiler might change, so the
> the best fix is to just use the proper std::atomic type,
> because that is guaranteed to always be safe. And the compiled
> code should be effectively unchanged.
>
> BUG=556469
> NOTRY=True
>
> Committed: https://crrev.com/5e58730d6fe40ef7cead75954ef5b1c05dea6d4b
> Cr-Commit-Position: refs/heads/master@{#363347}
TBR=esprehn@chromium.org,glider@chromium.org,haraken@chromium.org,yutak@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=556469
Committed: https://crrev.com/df707658fcdb00877c97b66bd473b9117ff57b15
Cr-Commit-Position: refs/heads/master@{#363348}
Patch Set 1 #Messages
Total messages: 6 (2 generated)
|