Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 15018013: Revert 198736 "Land Recent QUIC changes" (Closed)

Created:
7 years, 7 months ago by csharp
Modified:
7 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 198736 "Land Recent QUIC changes" Caused compile failures on the "Google Chrome ChromeOS" builder: cc1plus: warnings being treated as errors net/quic/quic_utils.cc:14:error: integer constant is too large for 'unsigned long' type net/quic/quic_utils.cc:15:error: integer constant is too large for 'unsigned long' type make: *** [out/Release/obj.target/net/net/quic/quic_utils.o] Error 1 > Land Recent QUIC changes > > Implement header compression/decompression in ReliableQuicStream. > > Merge internal change: 44867738 > > > QUIC: deflake proof_test. > > The current proof_test removes a byte from the start of the signature in order > to make it invalid. However, the signature is a big-endian number and, ~1% of > the time, the first byte will be zero - thus removing it doesn't change the > number. > > This change adds a non-zero byte to the start of the signature instead. > > Merge internal change: 44803399 > > Replace calls to scoped_ptr(NULL) with calls to scoped_ptr(). > > Merge internal change: 44799980 > > Add a blank line in order to get the dependencies correct for rebuild. > > Merge internal change: 44796024 > > Fix "large integer implicitly truncated to unsigned type" > > Merge internal change: 44793986 > > QUIC: compress certificates. > > This change causes server certificates to be compressed using three tricks: > 1) The client can advertise sets of common certificates that the server can > then simply reference. This change contains "common certificate set 0", > which is the set of the intermediates used twice or more in the Alexa top > 5000. It's temporary because it's missing GIAG2 which we'll want to > include soon. > 2) The client can send 64-bit, FNV-1a hashes of certificates that it already > has and the server can reference them by hash. > 3) Otherwise, certifciates are gzip compressed with a dictionary that > includes any certificates compressed using the previous two methods and a > 1500 byte lump of common substrings. (Again, taken from the Alexa top 5000) > > POKE=1 > > Merge internal change: 44792710 > > R=rch@chromium.org > > Review URL: https://chromiumcodereview.appspot.com/14651009 TBR=rtenneti@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198764

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -23897 lines) Patch
M trunk/src/android_webview/tools/third_party_files_whitelist.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D trunk/src/net/base/iovec.h View 1 chunk +0 lines, -18 lines 0 comments Download
M trunk/src/net/net.gyp View 6 chunks +0 lines, -16 lines 0 comments Download
D trunk/src/net/quic/crypto/cert_compressor.h View 1 chunk +0 lines, -55 lines 0 comments Download
D trunk/src/net/quic/crypto/cert_compressor.cc View 1 chunk +0 lines, -641 lines 0 comments Download
D trunk/src/net/quic/crypto/cert_compressor_test.cc View 1 chunk +0 lines, -140 lines 0 comments Download
D trunk/src/net/quic/crypto/common_cert_set.h View 1 chunk +0 lines, -62 lines 0 comments Download
D trunk/src/net/quic/crypto/common_cert_set.cc View 1 chunk +0 lines, -135 lines 0 comments Download
D trunk/src/net/quic/crypto/common_cert_set_0.c View 1 chunk +0 lines, -221 lines 0 comments Download
D trunk/src/net/quic/crypto/common_cert_set_1_50.inc View 1 chunk +0 lines, -9606 lines 0 comments Download
D trunk/src/net/quic/crypto/common_cert_set_51_100.inc View 1 chunk +0 lines, -11305 lines 0 comments Download
D trunk/src/net/quic/crypto/common_cert_set_test.cc View 1 chunk +0 lines, -109 lines 0 comments Download
M trunk/src/net/quic/crypto/crypto_handshake.h View 5 chunks +1 line, -8 lines 0 comments Download
M trunk/src/net/quic/crypto/crypto_handshake.cc View 10 chunks +30 lines, -37 lines 0 comments Download
M trunk/src/net/quic/crypto/crypto_protocol.h View 1 chunk +0 lines, -2 lines 0 comments Download
MM trunk/src/net/quic/crypto/crypto_server_config.cc View 5 chunks +32 lines, -19 lines 0 comments Download
M trunk/src/net/quic/crypto/null_encrypter.cc View 1 chunk +1 line, -1 line 0 comments Download
D trunk/src/net/quic/crypto/proof_test.cc View 1 chunk +0 lines, -58 lines 0 comments Download
M trunk/src/net/quic/quic_crypto_client_stream.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/net/quic/quic_framer.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/net/quic/quic_http_stream_test.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M trunk/src/net/quic/quic_network_transaction_unittest.cc View 3 chunks +1 line, -3 lines 0 comments Download
M trunk/src/net/quic/quic_protocol.h View 3 chunks +1 line, -8 lines 0 comments Download
M trunk/src/net/quic/quic_session.h View 5 chunks +0 lines, -17 lines 0 comments Download
M trunk/src/net/quic/quic_session.cc View 2 chunks +0 lines, -19 lines 0 comments Download
M trunk/src/net/quic/quic_session_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
D trunk/src/net/quic/quic_spdy_compressor.h View 1 chunk +0 lines, -38 lines 0 comments Download
D trunk/src/net/quic/quic_spdy_compressor.cc View 1 chunk +0 lines, -50 lines 0 comments Download
D trunk/src/net/quic/quic_spdy_compressor_test.cc View 1 chunk +0 lines, -46 lines 0 comments Download
D trunk/src/net/quic/quic_spdy_decompressor.h View 1 chunk +0 lines, -64 lines 0 comments Download
D trunk/src/net/quic/quic_spdy_decompressor.cc View 1 chunk +0 lines, -138 lines 0 comments Download
D trunk/src/net/quic/quic_spdy_decompressor_test.cc View 1 chunk +0 lines, -57 lines 0 comments Download
M trunk/src/net/quic/quic_stream_sequencer.h View 3 chunks +2 lines, -17 lines 0 comments Download
M trunk/src/net/quic/quic_stream_sequencer.cc View 3 chunks +2 lines, -84 lines 0 comments Download
M trunk/src/net/quic/quic_stream_sequencer_test.cc View 3 chunks +0 lines, -187 lines 0 comments Download
M trunk/src/net/quic/quic_utils.h View 1 chunk +0 lines, -10 lines 0 comments Download
M trunk/src/net/quic/quic_utils.cc View 3 chunks +0 lines, -36 lines 0 comments Download
M trunk/src/net/quic/reliable_quic_stream.h View 5 chunks +5 lines, -32 lines 0 comments Download
M trunk/src/net/quic/reliable_quic_stream.cc View 5 chunks +1 line, -177 lines 0 comments Download
M trunk/src/net/quic/reliable_quic_stream_test.cc View 2 chunks +32 lines, -241 lines 0 comments Download
D trunk/src/net/quic/spdy_utils.h View 1 chunk +0 lines, -23 lines 0 comments Download
D trunk/src/net/quic/spdy_utils.cc View 1 chunk +0 lines, -25 lines 0 comments Download
M trunk/src/net/quic/test_tools/crypto_test_utils.h View 2 chunks +0 lines, -8 lines 0 comments Download
M trunk/src/net/quic/test_tools/crypto_test_utils.cc View 2 chunks +1 line, -63 lines 0 comments Download
M trunk/src/net/quic/test_tools/quic_test_utils.h View 3 chunks +1 line, -15 lines 0 comments Download
M trunk/src/net/quic/test_tools/quic_test_utils.cc View 3 chunks +0 lines, -8 lines 0 comments Download
M trunk/src/net/quic/test_tools/simple_quic_framer.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M trunk/src/net/tools/quic/quic_reliable_server_stream_test.cc View 2 chunks +1 line, -12 lines 0 comments Download
M trunk/src/net/tools/quic/quic_spdy_client_stream.cc View 1 chunk +1 line, -5 lines 0 comments Download
M trunk/src/net/tools/quic/quic_spdy_server_stream.cc View 2 chunks +1 line, -5 lines 0 comments Download
M trunk/src/net/tools/quic/spdy_utils.h View 2 chunks +0 lines, -10 lines 0 comments Download
M trunk/src/net/tools/quic/spdy_utils.cc View 2 chunks +11 lines, -26 lines 0 comments Download
M trunk/src/net/tools/quic/test_tools/quic_test_utils.h View 3 chunks +3 lines, -21 lines 0 comments Download
M trunk/src/net/tools/quic/test_tools/quic_test_utils.cc View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
csharp
7 years, 7 months ago (2013-05-07 17:55:38 UTC) #1
csharp
7 years, 7 months ago (2013-05-07 17:56:31 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r198764.

Powered by Google App Engine
This is Rietveld 408576698