Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Unified Diff: trunk/src/net/tools/quic/spdy_utils.cc

Issue 15018013: Revert 198736 "Land Recent QUIC changes" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/net/tools/quic/spdy_utils.h ('k') | trunk/src/net/tools/quic/test_tools/quic_test_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/net/tools/quic/spdy_utils.cc
===================================================================
--- trunk/src/net/tools/quic/spdy_utils.cc (revision 198763)
+++ trunk/src/net/tools/quic/spdy_utils.cc (working copy)
@@ -96,8 +96,7 @@
PopulateSpdyHeaderBlock(headers, block, true);
}
-// static
-SpdyHeaderBlock SpdyUtils::RequestHeadersToSpdyHeaders(
+string SpdyUtils::SerializeRequestHeaders(
const BalsaHeaders& request_headers) {
string scheme;
string host_and_port;
@@ -130,38 +129,24 @@
if (block.find("host") != block.end()) {
block.erase(block.find("host"));
}
- return block;
-}
-// static
-string SpdyUtils::SerializeRequestHeaders(const BalsaHeaders& request_headers) {
- SpdyHeaderBlock block = RequestHeadersToSpdyHeaders(request_headers);
- return SerializeUncompressedHeaders(block);
+ int length = SpdyFramer::GetSerializedLength(kSpdyVersion3, &block);
+ SpdyFrameBuilder builder(length);
+ SpdyFramer::WriteHeaderBlock(&builder, kSpdyVersion3, &block);
+ scoped_ptr<SpdyFrame> headers(builder.take());
+ return string(headers->data(), length);
}
-// static
-SpdyHeaderBlock SpdyUtils::ResponseHeadersToSpdyHeaders(
+string SpdyUtils::SerializeResponseHeaders(
const BalsaHeaders& response_headers) {
SpdyHeaderBlock block;
PopulateSpdyResponseHeaderBlock(response_headers, &block);
- return block;
-}
-// static
-string SpdyUtils::SerializeResponseHeaders(
- const BalsaHeaders& response_headers) {
- SpdyHeaderBlock block = ResponseHeadersToSpdyHeaders(response_headers);
-
- return SerializeUncompressedHeaders(block);
-}
-
-// static
-string SpdyUtils::SerializeUncompressedHeaders(const SpdyHeaderBlock& headers) {
- int length = SpdyFramer::GetSerializedLength(kSpdyVersion3, &headers);
+ int length = SpdyFramer::GetSerializedLength(kSpdyVersion3, &block);
SpdyFrameBuilder builder(length);
- SpdyFramer::WriteHeaderBlock(&builder, kSpdyVersion3, &headers);
- scoped_ptr<SpdyFrame> block(builder.take());
- return string(block->data(), length);
+ SpdyFramer::WriteHeaderBlock(&builder, kSpdyVersion3, &block);
+ scoped_ptr<SpdyFrame> headers(builder.take());
+ return string(headers->data(), length);
}
bool IsSpecialSpdyHeader(SpdyHeaderBlock::const_iterator header,
« no previous file with comments | « trunk/src/net/tools/quic/spdy_utils.h ('k') | trunk/src/net/tools/quic/test_tools/quic_test_utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698