Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Unified Diff: pkg/analyzer/lib/src/task/strong/info.dart

Issue 1501633003: Strong-mode error code validation "enum" (#25117). (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/src/task/strong/info.dart
diff --git a/pkg/analyzer/lib/src/task/strong/info.dart b/pkg/analyzer/lib/src/task/strong/info.dart
index 0c2e48a58309f2634fbc8918cc8c4e6d389ad315..203637abf887577dc205f733281d3f45a0fefaa1 100644
--- a/pkg/analyzer/lib/src/task/strong/info.dart
+++ b/pkg/analyzer/lib/src/task/strong/info.dart
@@ -485,6 +485,32 @@ abstract class StaticError extends StaticInfo {
// Analyzer instead has template strings, and replaces '{0}' with the first
// argument.
abstract class StaticInfo {
+ /// Strong-mode error code names.
+ ///
+ /// Used for error code configuration validation in `.analysis_options`.
+ static const List<String> names = const [
Jennifer Messerly 2015/12/05 00:59:27 consider: lazy initialized Set for faster lookup?
pquitslund 2015/12/06 17:07:18 I talked myself out of this with the ErrorCodes en
+ //
+ // Manually populated.
+ //
+ 'STRONG_MODE_ASSIGNMENT_CAST',
+ 'STRONG_MODE_DOWN_CAST_COMPOSITE',
+ 'STRONG_MODE_DOWN_CAST_IMPLICIT',
+ 'STRONG_MODE_DYNAMIC_CAST',
+ 'STRONG_MODE_DYNAMIC_INVOKE',
+ 'STRONG_MODE_INFERRED_TYPE',
+ 'STRONG_MODE_INFERRED_TYPE_ALLOCATION',
+ 'STRONG_MODE_INFERRED_TYPE_CLOSURE',
+ 'STRONG_MODE_INFERRED_TYPE_LITERAL',
+ 'STRONG_MODE_INVALID_FIELD_OVERRIDE',
+ 'STRONG_MODE_INVALID_METHOD_OVERRIDE',
+ 'STRONG_MODE_INVALID_PARAMETER_DECLARATION',
+ 'STRONG_MODE_INVALID_SUPER_INVOCATION',
+ 'STRONG_MODE_INVALID_VARIABLE_DECLARATION',
+ 'STRONG_MODE_NON_GROUND_TYPE_CHECK_INFO',
+ 'STRONG_MODE_STATIC_TYPE_ERROR',
+ 'STRONG_MODE_UNINFERRED_CLOSURE',
+ ];
+
List<Object> get arguments => [node];
String get name;

Powered by Google App Engine
This is Rietveld 408576698