Strong-mode error code validation "enum" (#25117).

pkg/analyzer/lib/src/task/options.dart

Index: pkg/analyzer/lib/src/task/options.dart
diff --git a/pkg/analyzer/lib/src/task/options.dart b/pkg/analyzer/lib/src/task/options.dart
index 45faf41d29e169addec6eeee5c928ce4968ef617..b1e60985b2405437651bcbe168c1bd89fcfef298 100644
--- a/pkg/analyzer/lib/src/task/options.dart
+++ b/pkg/analyzer/lib/src/task/options.dart
@@ -12,6 +12,7 @@ import 'package:analyzer/src/generated/java_engine.dart';
 import 'package:analyzer/src/generated/source.dart';
 import 'package:analyzer/src/generated/utilities_general.dart';
 import 'package:analyzer/src/task/general.dart';
+import 'package:analyzer/src/task/strong/info.dart';
 import 'package:analyzer/task/general.dart';
 import 'package:analyzer/task/model.dart';
 import 'package:source_span/source_span.dart';
@@ -125,6 +126,10 @@ class ErrorFilterOptionValidator extends OptionsValidator {
       new List.from(AnalyzerOptions.ignoreSynonyms)
         ..addAll(AnalyzerOptions.includeSynonyms));
 
+  bool recognizedErrorCode(String name) =>
+      ErrorCode.values.any((ErrorCode code) => code.name == name) ||
+          StaticInfo.names.any((String code) => code == name);

[Jennifer Messerly, 2015/12/05 00:59:27]

StaticInfo.names.contains?

[pquitslund, 2015/12/06 17:07:18]

Ha!  Good catch.  Done.

+
   @override
   void validate(ErrorReporter reporter, Map<String, YamlNode> options) {
     var analyzer = options[AnalyzerOptions.analyzer];
@@ -138,7 +143,7 @@ class ErrorFilterOptionValidator extends OptionsValidator {
       filters.nodes.forEach((k, v) {
         if (k is YamlScalar) {
           value = toUpperCase(k.value);
-          if (!ErrorCode.values.any((ErrorCode code) => code.name == value)) {
+          if (!recognizedErrorCode(value)) {
             reporter.reportErrorForSpan(
                 AnalysisOptionsWarningCode.UNRECOGNIZED_ERROR_CODE,
                 k.span,