Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 15015006: HTML Media Capture: Update implementation, part 1. (Closed)

Created:
7 years, 7 months ago by Raphael Kubo da Costa (rakuco)
Modified:
7 years, 5 months ago
CC:
blink-reviews, jamesr, eae+blinkwatch, abarth_chromum.org, kinuko, adamk+blink_chromium.org, jeez
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

The most recent version of the HTML Media Capture spec changes the `capture' attribute from an enum to a boolean (the values that used to be passed to the enum are now supposed to be extracted from the `accept' attribute). For now, add a `mediaCaptureEnabled' field to WebFileChooserParams and FileChooserSettings that coexists with the existing `capture' field while the Chromium side of the changes is done. R=abarth@chromium.org,eseidel@chromium.org,jochen@chromium.org BUG=240252 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153676

Patch Set 1 #

Total comments: 1

Patch Set 2 : Patch v2 #

Patch Set 3 : Minor fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M Source/WebKit/chromium/src/ChromeClientImpl.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/FileInputType.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/platform/FileChooser.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M public/web/WebFileChooserParams.h View 1 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
benm (inactive)
FWIW, I'm not a reviewer but seems reasonable from a Blink perspective. https://codereview.chromium.org/15015006/diff/1/Source/core/html/HTMLInputElement.h File Source/core/html/HTMLInputElement.h ...
7 years, 7 months ago (2013-05-23 13:24:32 UTC) #1
benm (inactive)
On 2013/05/23 13:24:32, benm wrote: > FWIW, I'm not a reviewer but seems reasonable from ...
7 years, 7 months ago (2013-05-23 15:08:38 UTC) #2
Raphael Kubo da Costa (rakuco)
7 years, 5 months ago (2013-07-03 15:00:29 UTC) #3
Raphael Kubo da Costa (rakuco)
+jochen,tkent
7 years, 5 months ago (2013-07-04 17:50:07 UTC) #4
Raphael Kubo da Costa (rakuco)
FWIW, part 2 is here: https://codereview.chromium.org/18332015 and can be committed after https://codereview.chromium.org/14758008 lands.
7 years, 5 months ago (2013-07-04 17:56:50 UTC) #5
jochen (gone - plz use gerrit)
patchset 3 lgtm
7 years, 5 months ago (2013-07-08 09:13:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raphael.kubo.da.costa@intel.com/15015006/13001
7 years, 5 months ago (2013-07-08 11:31:47 UTC) #7
commit-bot: I haz the power
7 years, 5 months ago (2013-07-08 12:48:13 UTC) #8
Message was sent while issue was closed.
Change committed as 153676

Powered by Google App Engine
This is Rietveld 408576698