Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 18332015: HTML Media Capture: Update implementation, part 2. (Closed)

Created:
7 years, 5 months ago by Raphael Kubo da Costa (rakuco)
Modified:
7 years, 5 months ago
CC:
blink-reviews, eae+blinkwatch, kinuko, dglazkov+blink, adamk+blink_chromium.org, jeez, do-not-use
Base URL:
https://chromium.googlesource.com/chromium/blink.git@update-media-capture-implementation-part1
Visibility:
Public.

Description

HTML Media Capture: Update implementation, part 2. The most recent version of the HTML Media Capture spec changes the `capture' attribute from an enum to a boolean (the values that used to be passed to the enum are now supposed to be extracted from the `accept' attribute). Now that the Chromium side has landed, make the `capture' attribute in HTMLInputElement a boolean and adjust the layout tests accordingly. R=abarth@chromium.org,eseidel@chromium.org,jochen@chromium.org BUG=240252 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153804

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -48 lines) Patch
M LayoutTests/fast/forms/file/file-input-capture.html View 1 chunk +19 lines, -14 lines 0 comments Download
M LayoutTests/fast/forms/file/file-input-capture-expected.txt View 1 chunk +14 lines, -8 lines 0 comments Download
M Source/WebKit/chromium/src/ChromeClientImpl.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/html/FileInputType.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/html/HTMLInputElement.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/html/HTMLInputElement.cpp View 1 1 chunk +12 lines, -16 lines 0 comments Download
M Source/core/html/HTMLInputElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/UseCounter.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/page/UseCounter.cpp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/platform/FileChooser.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
jochen (gone - plz use gerrit)
lgtm
7 years, 5 months ago (2013-07-08 09:33:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raphael.kubo.da.costa@intel.com/18332015/4001
7 years, 5 months ago (2013-07-09 14:51:54 UTC) #2
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_python_tests, webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=15476
7 years, 5 months ago (2013-07-09 15:13:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raphael.kubo.da.costa@intel.com/18332015/4001
7 years, 5 months ago (2013-07-09 15:42:27 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=15483
7 years, 5 months ago (2013-07-09 16:17:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raphael.kubo.da.costa@intel.com/18332015/4001
7 years, 5 months ago (2013-07-09 18:44:51 UTC) #6
commit-bot: I haz the power
7 years, 5 months ago (2013-07-09 19:19:20 UTC) #7
Message was sent while issue was closed.
Change committed as 153804

Powered by Google App Engine
This is Rietveld 408576698