Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Unified Diff: chrome/browser/tab_contents/tab_contents_view_mac.mm

Issue 150132: First cut at popup blocking for Mac. Remove ifdefs in cross-platform code. Im... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/tab_contents/tab_contents_view_mac.mm
===================================================================
--- chrome/browser/tab_contents/tab_contents_view_mac.mm (revision 19587)
+++ chrome/browser/tab_contents/tab_contents_view_mac.mm (working copy)
@@ -48,12 +48,15 @@
new RenderWidgetHostViewMac(render_widget_host);
// Fancy layout comes later; for now just make it our size and resize it
- // with us.
+ // with us. In case there are other siblings of the content area, we want
+ // to make sure the content area is on the bottom so other things draw over
+ // it.
NSView* view_view = view->native_view();
- [cocoa_view_.get() addSubview:view_view];
[view_view setFrame:[cocoa_view_.get() bounds]];
[view_view setAutoresizingMask:NSViewWidthSizable | NSViewHeightSizable];
-
+ [cocoa_view_.get() addSubview:view_view
+ positioned:NSWindowBelow
+ relativeTo:nil];
return view;
}

Powered by Google App Engine
This is Rietveld 408576698