Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2580)

Unified Diff: chrome/browser/tab_contents/tab_contents.cc

Issue 150132: First cut at popup blocking for Mac. Remove ifdefs in cross-platform code. Im... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/tab_contents/tab_contents.cc
===================================================================
--- chrome/browser/tab_contents/tab_contents.cc (revision 19587)
+++ chrome/browser/tab_contents/tab_contents.cc (working copy)
@@ -771,7 +771,6 @@
if (!delegate_)
return;
-#if defined(OS_WIN) || defined(OS_LINUX)
if ((disposition == NEW_POPUP) && !user_gesture &&
!CommandLine::ForCurrentProcess()->HasSwitch(
switches::kDisablePopupBlocking)) {
@@ -786,11 +785,6 @@
user_gesture);
}
PopupNotificationVisibilityChanged(ShowingBlockedPopupNotification());
-#else
- // TODO(port): implement the popup blocker stuff
- delegate_->AddNewContents(this, new_contents, disposition, initial_pos,
- user_gesture);
-#endif
}
void TabContents::CloseAllSuppressedPopups() {
@@ -1084,7 +1078,6 @@
det);
}
-#if defined(OS_WIN) || defined(OS_LINUX)
void TabContents::CreateBlockedPopupContainerIfNecessary() {
if (blocked_popups_)
return;
@@ -1098,7 +1091,6 @@
CreateBlockedPopupContainerIfNecessary();
blocked_popups_->AddTabContents(new_contents, initial_pos, host);
}
-#endif
// TODO(brettw) This should be on the TabContentsView.
void TabContents::RepositionSupressedPopupsToFit() {

Powered by Google App Engine
This is Rietveld 408576698