First cut at popup blocking for Mac. Remove ifdefs in cross-platform code. Im...

First cut at popup blocking for Mac. Remove ifdefs in cross-platform code. Implement displaying of notification, menu of popups still to come.
BUG=13160
TEST=popup notification should display and popups blocked accordingly. Can close notification widget to prevent more notifications for this tab.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19735

[rohitrao (ping after 24h), 2009-07-01 15:04:17]

LGTM

One concern is that if this is going to make it into a dev channel release
before the popup menu is done, unilaterally blocking popups may be worse than
not blocking them at all, for websites that require popups to work.

http://codereview.chromium.org/150132/diff/32/1017
File chrome/browser/cocoa/blocked_popup_container_controller.mm (right):

http://codereview.chromium.org/150132/diff/32/1017#newcode41
Line 41: // used to represet the "view".
Typo: represet

http://codereview.chromium.org/150132/diff/32/1017#newcode63
Line 63: const float kWidth = 200.0;
static?

http://codereview.chromium.org/150132/diff/32/1017#newcode108
Line 108: // Returns the NSView container of the RWHVMac. We insert our popup
blocker
"NSView container" -> "parent", or maybe explicitly mention that it's a sibling
of RWHVMac.

http://codereview.chromium.org/150132/diff/32/1017#newcode121
Line 121: // Position the view at the bottom left corner, always leaving room
for the
If it's in the bottom left corner, do we have to worry about the statusbar?

http://codereview.chromium.org/150132/diff/32/1017#newcode142
Line 142: #if 0
Why is this commented out?

[pink (ping after 24hrs), 2009-07-01 15:49:15]

http://codereview.chromium.org/150132/diff/32/1017
File chrome/browser/cocoa/blocked_popup_container_controller.mm (right):

http://codereview.chromium.org/150132/diff/32/1017#newcode41
Line 41: // used to represet the "view".
On 2009/07/01 15:04:17, rohitrao wrote:
> Typo: represet

Done.

http://codereview.chromium.org/150132/diff/32/1017#newcode63
Line 63: const float kWidth = 200.0;
On 2009/07/01 15:04:17, rohitrao wrote:
> static?

Done.

http://codereview.chromium.org/150132/diff/32/1017#newcode108
Line 108: // Returns the NSView container of the RWHVMac. We insert our popup
blocker
On 2009/07/01 15:04:17, rohitrao wrote:
> "NSView container" -> "parent", or maybe explicitly mention that it's a
sibling
> of RWHVMac.
> 

Done.

http://codereview.chromium.org/150132/diff/32/1017#newcode121
Line 121: // Position the view at the bottom left corner, always leaving room
for the
On 2009/07/01 15:04:17, rohitrao wrote:
> If it's in the bottom left corner, do we have to worry about the statusbar?

typo, bottom right corner. Directions are hard, let's go shopping.

http://codereview.chromium.org/150132/diff/32/1017#newcode142
Line 142: #if 0
On 2009/07/01 15:04:17, rohitrao wrote:
> Why is this commented out?

todo added.