Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 150103007: Use fastGetAttribute in more places (Closed)

Created:
6 years, 10 months ago by rwlbuis
Modified:
6 years, 10 months ago
Reviewers:
Inactive
CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Use fastGetAttribute in more places We can use fastGetAttribute in more places, as long as it is not an SVG animatable or style property. The HTMLTableSectionElement getAttributes don't have to be replaced since the code is not needed anymore, HTMLTableSectionElement.idl uses Reflect for these getters/setters. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167114

Patch Set 1 #

Patch Set 2 : Add more instances #

Total comments: 2

Patch Set 3 : Use fastGEtAttribute more for titleAttr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -69 lines) Patch
M Source/core/dom/Element.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/ShadowTreeStyleSheetCollection.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/StyleSheetCandidate.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLElement.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLHtmlElement.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLImageElement.cpp View 1 2 2 chunks +5 lines, -4 lines 0 comments Download
M Source/core/html/HTMLInputElement.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLTableCellElement.cpp View 1 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/HTMLTableSectionElement.h View 1 1 chunk +0 lines, -12 lines 0 comments Download
M Source/core/html/HTMLTableSectionElement.cpp View 1 1 chunk +0 lines, -40 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
rwlbuis
Simple replacement patch, bots seem to like it, all green :)
6 years, 10 months ago (2014-02-06 21:42:12 UTC) #1
Inactive
https://codereview.chromium.org/150103007/diff/20001/Source/core/dom/Element.cpp File Source/core/dom/Element.cpp (right): https://codereview.chromium.org/150103007/diff/20001/Source/core/dom/Element.cpp#newcode2969 Source/core/dom/Element.cpp:2969: const AtomicString& value = fastGetAttribute(HTMLNames::spellcheckAttr); HTMLNames:: is likely not ...
6 years, 10 months ago (2014-02-13 16:03:43 UTC) #2
rwlbuis
On 2014/02/13 16:03:43, Chris Dumez wrote: > https://codereview.chromium.org/150103007/diff/20001/Source/core/dom/Element.cpp > File Source/core/dom/Element.cpp (right): > > https://codereview.chromium.org/150103007/diff/20001/Source/core/dom/Element.cpp#newcode2969 ...
6 years, 10 months ago (2014-02-13 16:51:25 UTC) #3
Inactive
On 2014/02/13 16:51:25, rwlbuis wrote: > On 2014/02/13 16:03:43, Chris Dumez wrote: > > > ...
6 years, 10 months ago (2014-02-13 17:19:35 UTC) #4
rwlbuis
On 2014/02/13 17:19:35, Chris Dumez wrote: > On 2014/02/13 16:51:25, rwlbuis wrote: > > On ...
6 years, 10 months ago (2014-02-13 17:44:42 UTC) #5
Inactive
lgtm
6 years, 10 months ago (2014-02-13 18:56:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/150103007/140001
6 years, 10 months ago (2014-02-13 18:56:32 UTC) #7
commit-bot: I haz the power
6 years, 10 months ago (2014-02-13 21:19:18 UTC) #8
Message was sent while issue was closed.
Change committed as 167114

Powered by Google App Engine
This is Rietveld 408576698