Use fastGetAttribute in more places

Use fastGetAttribute in more places

We can use fastGetAttribute in more places, as long as it is not an SVG animatable or style property. The HTMLTableSectionElement getAttributes don't have to be replaced since the code is not needed anymore,  HTMLTableSectionElement.idl uses Reflect for these getters/setters.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167114

[rwlbuis, 2014-02-06 21:42:12]

Simple replacement patch, bots seem to like it, all green :)

[Inactive, 2014-02-13 16:03:43]

https://codereview.chromium.org/150103007/diff/20001/Source/core/dom/Element.cpp
File Source/core/dom/Element.cpp (right):

https://codereview.chromium.org/150103007/diff/20001/Source/core/dom/Element....
Source/core/dom/Element.cpp:2969: const AtomicString& value =
fastGetAttribute(HTMLNames::spellcheckAttr);
HTMLNames:: is likely not needed.

https://codereview.chromium.org/150103007/diff/20001/Source/core/html/HTMLIma...
File Source/core/html/HTMLImageElement.cpp (right):

https://codereview.chromium.org/150103007/diff/20001/Source/core/html/HTMLIma...
Source/core/html/HTMLImageElement.cpp:189: return getAttribute(titleAttr);
Why don't we use fastGetAttribute for this one?

[rwlbuis, 2014-02-13 16:51:25]

On 2014/02/13 16:03:43, Chris Dumez wrote:
>
https://codereview.chromium.org/150103007/diff/20001/Source/core/dom/Element.cpp
> File Source/core/dom/Element.cpp (right):
> 
>
https://codereview.chromium.org/150103007/diff/20001/Source/core/dom/Element....
> Source/core/dom/Element.cpp:2969: const AtomicString& value =
> fastGetAttribute(HTMLNames::spellcheckAttr);
> HTMLNames:: is likely not needed.

Correct, will fix.

>
https://codereview.chromium.org/150103007/diff/20001/Source/core/html/HTMLIma...
> File Source/core/html/HTMLImageElement.cpp (right):
> 
>
https://codereview.chromium.org/150103007/diff/20001/Source/core/html/HTMLIma...
> Source/core/html/HTMLImageElement.cpp:189: return getAttribute(titleAttr);
> Why don't we use fastGetAttribute for this one?

That should work, or if not the bots will show it. Will make a new patch, also I
noticed getAttribute(titleAttr) is used in more places, will include them too.

[Inactive, 2014-02-13 17:19:35]

On 2014/02/13 16:51:25, rwlbuis wrote:
> On 2014/02/13 16:03:43, Chris Dumez wrote:
> >
>
https://codereview.chromium.org/150103007/diff/20001/Source/core/dom/Element.cpp
> > File Source/core/dom/Element.cpp (right):
> > 
> >
>
https://codereview.chromium.org/150103007/diff/20001/Source/core/dom/Element....
> > Source/core/dom/Element.cpp:2969: const AtomicString& value =
> > fastGetAttribute(HTMLNames::spellcheckAttr);
> > HTMLNames:: is likely not needed.
> 
> Correct, will fix.
> 
> >
>
https://codereview.chromium.org/150103007/diff/20001/Source/core/html/HTMLIma...
> > File Source/core/html/HTMLImageElement.cpp (right):
> > 
> >
>
https://codereview.chromium.org/150103007/diff/20001/Source/core/html/HTMLIma...
> > Source/core/html/HTMLImageElement.cpp:189: return getAttribute(titleAttr);
> > Why don't we use fastGetAttribute for this one?
> 
> That should work, or if not the bots will show it. Will make a new patch, also
I
> noticed getAttribute(titleAttr) is used in more places, will include them too.

I see some failures on the linux_blink bot that are likely related.

[rwlbuis, 2014-02-13 17:44:42]

On 2014/02/13 17:19:35, Chris Dumez wrote:
> On 2014/02/13 16:51:25, rwlbuis wrote:
> > On 2014/02/13 16:03:43, Chris Dumez wrote:
> > >
> >
>
https://codereview.chromium.org/150103007/diff/20001/Source/core/dom/Element.cpp
> > > File Source/core/dom/Element.cpp (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/150103007/diff/20001/Source/core/dom/Element....
> > > Source/core/dom/Element.cpp:2969: const AtomicString& value =
> > > fastGetAttribute(HTMLNames::spellcheckAttr);
> > > HTMLNames:: is likely not needed.
> > 
> > Correct, will fix.
> > 
> > >
> >
>
https://codereview.chromium.org/150103007/diff/20001/Source/core/html/HTMLIma...
> > > File Source/core/html/HTMLImageElement.cpp (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/150103007/diff/20001/Source/core/html/HTMLIma...
> > > Source/core/html/HTMLImageElement.cpp:189: return getAttribute(titleAttr);
> > > Why don't we use fastGetAttribute for this one?
> > 
> > That should work, or if not the bots will show it. Will make a new patch,
also
> I
> > noticed getAttribute(titleAttr) is used in more places, will include them
too.
> 
> I see some failures on the linux_blink bot that are likely related.

Correct, it seems rotateAttr can be animated (though not for animateMotion).
I'll take that part out.

[Inactive, 2014-02-13 18:56:21]

lgtm

[commit-bot: I haz the power, 2014-02-13 18:56:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rob.buis@samsung.com/150103007/140001

[commit-bot: I haz the power, 2014-02-13 21:19:18]

Change committed as 167114