Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Side by Side Diff: Source/core/dom/Element.cpp

Issue 150103007: Use fastGetAttribute in more places (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Use fastGEtAttribute more for titleAttr Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/core/dom/ShadowTreeStyleSheetCollection.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Peter Kelly (pmk@post.com) 4 * (C) 2001 Peter Kelly (pmk@post.com)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * (C) 2007 David Smith (catfish.man@gmail.com) 6 * (C) 2007 David Smith (catfish.man@gmail.com)
7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved. 7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved.
8 * (C) 2007 Eric Seidel (eric@webkit.org) 8 * (C) 2007 Eric Seidel (eric@webkit.org)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 1253 matching lines...) Expand 10 before | Expand all | Expand 10 after
1264 } 1264 }
1265 1265
1266 if (Element* parent = parentElement()) 1266 if (Element* parent = parentElement())
1267 return parent->locateNamespacePrefix(namespaceToLocate); 1267 return parent->locateNamespacePrefix(namespaceToLocate);
1268 1268
1269 return nullAtom; 1269 return nullAtom;
1270 } 1270 }
1271 1271
1272 KURL Element::baseURI() const 1272 KURL Element::baseURI() const
1273 { 1273 {
1274 const AtomicString& baseAttribute = getAttribute(baseAttr); 1274 const AtomicString& baseAttribute = fastGetAttribute(baseAttr);
1275 KURL base(KURL(), baseAttribute); 1275 KURL base(KURL(), baseAttribute);
1276 if (!base.protocol().isEmpty()) 1276 if (!base.protocol().isEmpty())
1277 return base; 1277 return base;
1278 1278
1279 ContainerNode* parent = parentNode(); 1279 ContainerNode* parent = parentNode();
1280 if (!parent) 1280 if (!parent)
1281 return base; 1281 return base;
1282 1282
1283 const KURL& parentBase = parent->baseURI(); 1283 const KURL& parentBase = parent->baseURI();
1284 if (parentBase.isNull()) 1284 if (parentBase.isNull())
(...skipping 1658 matching lines...) Expand 10 before | Expand all | Expand 10 after
2943 } 2943 }
2944 2944
2945 void Element::webkitRequestPointerLock() 2945 void Element::webkitRequestPointerLock()
2946 { 2946 {
2947 if (document().page()) 2947 if (document().page())
2948 document().page()->pointerLockController().requestPointerLock(this); 2948 document().page()->pointerLockController().requestPointerLock(this);
2949 } 2949 }
2950 2950
2951 SpellcheckAttributeState Element::spellcheckAttributeState() const 2951 SpellcheckAttributeState Element::spellcheckAttributeState() const
2952 { 2952 {
2953 const AtomicString& value = getAttribute(HTMLNames::spellcheckAttr); 2953 const AtomicString& value = fastGetAttribute(spellcheckAttr);
2954 if (value == nullAtom) 2954 if (value == nullAtom)
2955 return SpellcheckAttributeDefault; 2955 return SpellcheckAttributeDefault;
2956 if (equalIgnoringCase(value, "true") || equalIgnoringCase(value, "")) 2956 if (equalIgnoringCase(value, "true") || equalIgnoringCase(value, ""))
2957 return SpellcheckAttributeTrue; 2957 return SpellcheckAttributeTrue;
2958 if (equalIgnoringCase(value, "false")) 2958 if (equalIgnoringCase(value, "false"))
2959 return SpellcheckAttributeFalse; 2959 return SpellcheckAttributeFalse;
2960 2960
2961 return SpellcheckAttributeDefault; 2961 return SpellcheckAttributeDefault;
2962 } 2962 }
2963 2963
(...skipping 651 matching lines...) Expand 10 before | Expand all | Expand 10 after
3615 // Before doing so, we need to resolve issues in HTMLSelectElement::recalcLi stItems 3615 // Before doing so, we need to resolve issues in HTMLSelectElement::recalcLi stItems
3616 // and RenderMenuList::setText. See also https://bugs.webkit.org/show_bug.cg i?id=88405 3616 // and RenderMenuList::setText. See also https://bugs.webkit.org/show_bug.cg i?id=88405
3617 if (hasTagName(optionTag) || hasTagName(optgroupTag)) 3617 if (hasTagName(optionTag) || hasTagName(optgroupTag))
3618 return false; 3618 return false;
3619 if (FullscreenElementStack::isActiveFullScreenElement(this)) 3619 if (FullscreenElementStack::isActiveFullScreenElement(this))
3620 return false; 3620 return false;
3621 return true; 3621 return true;
3622 } 3622 }
3623 3623
3624 } // namespace WebCore 3624 } // namespace WebCore
OLDNEW
« no previous file with comments | « no previous file | Source/core/dom/ShadowTreeStyleSheetCollection.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698