Enabling ARM optimizations for Opus on Android and ChromeOS

third_party/opus/opus.gyp

Index: third_party/opus/opus.gyp
diff --git a/third_party/opus/opus.gyp b/third_party/opus/opus.gyp
index be0ae4e01efe77acc50a3ae8d6343e89849926c7..3d6347628df9be95bc0bf0768994097ee88453e1 100644
--- a/third_party/opus/opus.gyp
+++ b/third_party/opus/opus.gyp
@@ -5,10 +5,12 @@
 {
   'variables': {
     'conditions': [
-      ['OS=="android"', {
+      ['(OS=="android" or chromeos==1) and target_arch=="arm"', {

[Ami GONE FROM CHROMIUM, 2014/03/24 16:16:34]

Why not OS=="ios" (which would also likely mean target_arch=="armv7")?

         'use_opus_fixed_point%': 1,
+        'use_opus_arm_optimization%': 1,
       }, {
         'use_opus_fixed_point%': 0,
+        'use_opus_arm_optimization%': 0,
       }],
     ],
   },
@@ -65,6 +67,22 @@
           'sources/': [
             ['exclude', '/float/[^/]*_FLP.(h|c)$'],
           ],
+          'conditions': [
+            ['use_opus_arm_optimization==1', {
+              'defines': [
+                'OPUS_ARM_ASM',
+                'OPUS_ARM_INLINE_ASM',
+                'OPUS_ARM_INLINE_EDSP',
+                'OPUS_ARM_MAY_HAVE_EDSP',
+                'OPUS_ARM_MAY_HAVE_MEDIA',
+                'OPUS_ARM_MAY_HAVE_NEON',

[Ami GONE FROM CHROMIUM, 2014/03/24 16:16:34]

Does the run-time check this turns into
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/opus/s...
really work inside the chrome renderer sandbox?  If so that could be a boon to a
few other projects that have struggled with this recently (libvpx, libyuv).

+                'OPUS_HAVE_RTCD',
+              ],
+              'includes': [
+                'opus_srcs_arm.gypi',
+              ],
+            }],
+          ],
         }],
       ],
     },  # target opus