Enabling ARM optimizations for Opus on Android and ChromeOS

third_party/opus/opus.gyp

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     'conditions': [
-      ['OS=="android"', {
+      ['(OS=="android" or chromeos==1) and target_arch=="arm"', {

[Ami GONE FROM CHROMIUM, 2014/03/24 16:16:34]

Why not OS=="ios" (which would also likely mean target_arch=="armv7")?

         'use_opus_fixed_point%': 1,
+        'use_opus_arm_optimization%': 1,
       }, {
         'use_opus_fixed_point%': 0,
+        'use_opus_arm_optimization%': 0,
       }],
     ],
   },
   'targets': [
     {
       'target_name': 'opus',
       'type': 'static_library',
       'defines': [
         'OPUS_BUILD',
         'OPUS_EXPORT=',
@@ skipping 36 matching lines @@
         }, {
           'defines': [
             'FIXED_POINT',
           ],
           'include_dirs': [
             'src/silk/fixed',
           ],
           'sources/': [
             ['exclude', '/float/[^/]*_FLP.(h|c)$'],
           ],
+          'conditions': [
+            ['use_opus_arm_optimization==1', {
+              'defines': [
+                'OPUS_ARM_ASM',
+                'OPUS_ARM_INLINE_ASM',
+                'OPUS_ARM_INLINE_EDSP',
+                'OPUS_ARM_MAY_HAVE_EDSP',
+                'OPUS_ARM_MAY_HAVE_MEDIA',
+                'OPUS_ARM_MAY_HAVE_NEON',

[Ami GONE FROM CHROMIUM, 2014/03/24 16:16:34]

Does the run-time check this turns into
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/opus/s...
really work inside the chrome renderer sandbox?  If so that could be a boon to a
few other projects that have struggled with this recently (libvpx, libyuv).

+                'OPUS_HAVE_RTCD',
+              ],
+              'includes': [
+                'opus_srcs_arm.gypi',
+              ],
+            }],
+          ],
         }],
       ],
     },  # target opus
     {
       'target_name': 'opus_demo',
       'type': 'executable',
       'dependencies': [
         'opus'
       ],
       'conditions': [
@@ skipping 13 matching lines @@
       'sources': [
         'src/src/opus_demo.c',
       ],
       'include_dirs': [
         'src/celt',
         'src/silk',
       ],
     },  # target opus_demo
   ]
 }