Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 150093002: Change default mode of extension install verification (Closed)

Created:
6 years, 10 months ago by asargent_no_longer_on_chrome
Modified:
6 years, 10 months ago
Reviewers:
Finnur
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Change default mode of extension install verification Right now the default mode is to make requests against the server unless the experiment group says not to, and that may be contributing to some unexpected load we're seeing. So this CL changes it to not do that. It also adds some histograms to help measure the success rate and sources of requests to the server. [This is a resubmit of https://codereview.chromium.org/149353002 with a compile error fixed] BUG=335379 TBR=finnur@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247954

Patch Set 1 #

Patch Set 2 : compile fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -17 lines) Patch
M chrome/browser/extensions/extension_service.h View 1 chunk +6 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 5 chunks +36 lines, -5 lines 0 comments Download
M chrome/browser/extensions/install_signer.cc View 1 6 chunks +63 lines, -7 lines 0 comments Download
M chrome/browser/extensions/install_verifier.cc View 3 chunks +11 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
asargent_no_longer_on_chrome
Trying this again, hopefully now with 100% less compile failures.
6 years, 10 months ago (2014-01-30 06:22:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asargent@chromium.org/150093002/10001
6 years, 10 months ago (2014-01-30 06:26:09 UTC) #2
commit-bot: I haz the power
Retried try job too often on android_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_dbg&number=144595
6 years, 10 months ago (2014-01-30 07:58:15 UTC) #3
Finnur
LGTM
6 years, 10 months ago (2014-01-30 10:02:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asargent@chromium.org/150093002/10001
6 years, 10 months ago (2014-01-30 10:03:44 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-01-30 13:55:47 UTC) #6
Message was sent while issue was closed.
Change committed as 247954

Powered by Google App Engine
This is Rietveld 408576698