Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Unified Diff: chrome/browser/extensions/install_verifier.cc

Issue 150093002: Change default mode of extension install verification (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: compile fix Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/install_verifier.cc
diff --git a/chrome/browser/extensions/install_verifier.cc b/chrome/browser/extensions/install_verifier.cc
index 7f06c68ac03f299d2161d0b08be6470fcbba0784..642457dc8efd4419bfb0269bd4e5e641f435d294 100644
--- a/chrome/browser/extensions/install_verifier.cc
+++ b/chrome/browser/extensions/install_verifier.cc
@@ -30,6 +30,11 @@ enum VerifyStatus {
NONE = 0, // Do not request install signatures, and do not enforce them.
BOOTSTRAP, // Request install signatures, but do not enforce them.
ENFORCE, // Request install signatures, and enforce them.
+
+ // This is used in histograms - do not remove or reorder entries above! Also
+ // the "MAX" item below should always be the last element.
+
+ VERIFY_STATUS_MAX
};
#if defined(GOOGLE_CHROME_BUILD)
@@ -49,7 +54,7 @@ VerifyStatus GetExperimentStatus() {
return ENFORCE;
}
- VerifyStatus default_status = BOOTSTRAP;
+ VerifyStatus default_status = NONE;
if (group == "Enforce")
return ENFORCE;
@@ -141,6 +146,11 @@ bool InstallVerifier::NeedsVerification(const Extension& extension) {
}
void InstallVerifier::Init() {
+ UMA_HISTOGRAM_ENUMERATION("ExtensionInstallVerifier.ExperimentStatus",
+ GetExperimentStatus(), VERIFY_STATUS_MAX);
+ UMA_HISTOGRAM_ENUMERATION("ExtensionInstallVerifier.ActualStatus",
+ GetStatus(), VERIFY_STATUS_MAX);
+
const base::DictionaryValue* pref = prefs_->GetInstallSignature();
if (pref) {
scoped_ptr<InstallSignature> signature_from_prefs =
« no previous file with comments | « chrome/browser/extensions/install_signer.cc ('k') | chrome/browser/ui/webui/extensions/extension_settings_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698