include/effects/SkColorFilterImageFilter.h - Issue 1500923004: Matrix convolution bounds fix; affectsTransparentBlack fixes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/effects/SkColorFilterImageFilter.h

Issue 1500923004: Matrix convolution bounds fix; affectsTransparentBlack fixes. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Make filterPtr a required param for asAColorFilter. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: include/effects/SkColorFilterImageFilter.h

diff --git a/include/effects/SkColorFilterImageFilter.h b/include/effects/SkColorFilterImageFilter.h

index 200ec8650015c3e6f9f2b049b53168c2fe15a4d4..db5d842c2fa956032ecf9e5fbe23ac8930fe8954 100644

--- a/include/effects/SkColorFilterImageFilter.h

+++ b/include/effects/SkColorFilterImageFilter.h

@@ -25,7 +25,7 @@ protected:

bool onFilterImage(Proxy*, const SkBitmap& src, const Context&, SkBitmap* result,

SkIPoint* loc) const override;

bool onIsColorFilterNode(SkColorFilter**) const override;

- bool affectsTransparentBlack() const override;

+ bool canComputeFastBounds() const override;

private:

SkColorFilterImageFilter(SkColorFilter* cf,