src/effects/SkRectShaderImageFilter.cpp - Issue 1500923004: Matrix convolution bounds fix; affectsTransparentBlack fixes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkRectShaderImageFilter.cpp

Issue 1500923004: Matrix convolution bounds fix; affectsTransparentBlack fixes. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Make filterPtr a required param for asAColorFilter. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkRectShaderImageFilter.cpp

diff --git a/src/effects/SkRectShaderImageFilter.cpp b/src/effects/SkRectShaderImageFilter.cpp

index 14837d02b15680268368d06eb635bbc865392167..20d2900253ab27668fa26d5d5cca6a32c41d79ae 100644

--- a/src/effects/SkRectShaderImageFilter.cpp

+++ b/src/effects/SkRectShaderImageFilter.cpp

@@ -79,8 +79,8 @@ bool SkRectShaderImageFilter::onFilterImage(Proxy* proxy,

return true;

}

-bool SkRectShaderImageFilter::affectsTransparentBlack() const {

- return true;

+bool SkRectShaderImageFilter::canComputeFastBounds() const {

reed1 2015/12/04 21:01:03 nit: a comment explaining why we can't compute fas

Stephen White 2015/12/04 21:39:26 Done.

+ return false;

}

#ifndef SK_IGNORE_TO_STRING

« no previous file with comments | « src/effects/SkMatrixConvolutionImageFilter.cpp ('k') | no next file » | no next file with comments »