include/effects/SkLightingImageFilter.h - Issue 1500923004: Matrix convolution bounds fix; affectsTransparentBlack fixes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/effects/SkLightingImageFilter.h

Issue 1500923004: Matrix convolution bounds fix; affectsTransparentBlack fixes. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Alternate, more future-proof fix Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: include/effects/SkLightingImageFilter.h

diff --git a/include/effects/SkLightingImageFilter.h b/include/effects/SkLightingImageFilter.h

index fb356c52e43413a019d57ee7514b86713ae4a28d..33cfceccb2461307d0c67fa6d4eb5f196b49c551 100644

--- a/include/effects/SkLightingImageFilter.h

+++ b/include/effects/SkLightingImageFilter.h

@@ -49,7 +49,7 @@ protected:

void flatten(SkWriteBuffer&) const override;

const SkImageFilterLight* light() const { return fLight.get(); }

SkScalar surfaceScale() const { return fSurfaceScale; }

- bool affectsTransparentBlack() const override { return true; }

+ bool canComputeFastBounds() const override { return false; }

private:

typedef SkImageFilter INHERITED;