Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: include/effects/SkLightingImageFilter.h

Issue 1500923004: Matrix convolution bounds fix; affectsTransparentBlack fixes. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Alternate, more future-proof fix Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2012 The Android Open Source Project 2 * Copyright 2012 The Android Open Source Project
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #ifndef SkLightingImageFilter_DEFINED 8 #ifndef SkLightingImageFilter_DEFINED
9 #define SkLightingImageFilter_DEFINED 9 #define SkLightingImageFilter_DEFINED
10 10
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 SK_DECLARE_FLATTENABLE_REGISTRAR_GROUP() 42 SK_DECLARE_FLATTENABLE_REGISTRAR_GROUP()
43 43
44 protected: 44 protected:
45 SkLightingImageFilter(SkImageFilterLight* light, 45 SkLightingImageFilter(SkImageFilterLight* light,
46 SkScalar surfaceScale, 46 SkScalar surfaceScale,
47 SkImageFilter* input, 47 SkImageFilter* input,
48 const CropRect* cropRect); 48 const CropRect* cropRect);
49 void flatten(SkWriteBuffer&) const override; 49 void flatten(SkWriteBuffer&) const override;
50 const SkImageFilterLight* light() const { return fLight.get(); } 50 const SkImageFilterLight* light() const { return fLight.get(); }
51 SkScalar surfaceScale() const { return fSurfaceScale; } 51 SkScalar surfaceScale() const { return fSurfaceScale; }
52 bool affectsTransparentBlack() const override { return true; } 52 bool canComputeFastBounds() const override { return false; }
53 53
54 private: 54 private:
55 typedef SkImageFilter INHERITED; 55 typedef SkImageFilter INHERITED;
56 SkAutoTUnref<SkImageFilterLight> fLight; 56 SkAutoTUnref<SkImageFilterLight> fLight;
57 SkScalar fSurfaceScale; 57 SkScalar fSurfaceScale;
58 }; 58 };
59 59
60 #endif 60 #endif
OLDNEW
« no previous file with comments | « include/effects/SkColorFilterImageFilter.h ('k') | include/effects/SkMatrixConvolutionImageFilter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698