Use GL_chromium_color_buffer_float extensions

Use GL_chromium_color_buffer_float extensions

New GL_chromium_color_buffer_float extensions will require that GPU
command buffer clients use sized internal formats if they wish to render
to floating point textures.

BUG=329605
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167013

[piman, 2014-02-10 23:03:25]

LGTM FWIW

[oetuaho-nv, 2014-02-11 12:52:12]

On 2014/02/10 23:03:25, piman wrote:
> LGTM FWIW

Should I ask some Blink people specifically to also review this patch?

[piman, 2014-02-11 22:43:53]

On Tue, Feb 11, 2014 at 4:52 AM, <oetuaho@nvidia.com> wrote:

> On 2014/02/10 23:03:25, piman wrote:
>
>> LGTM FWIW
>>
>
> Should I ask some Blink people specifically to also review this patch?
>

kbr@ is the right reviewer.


>
> https://codereview.chromium.org/150083005/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[Ken Russell (switch to Gerrit), 2014-02-11 23:46:52]

Sorry for the delay reviewing this.

LGTM. Note that bajones@ has an outstanding patch refactoring GraphicsContext3D
and Extensions3D further, so one or the other of these CLs will need to be
rebased.

One question. (I know there isn't a getTexLevelParameter in ES 2.0 / WebGL 1.0,
but just checking.)

https://codereview.chromium.org/150083005/diff/1/Source/core/html/canvas/WebG...
File Source/core/html/canvas/WebGLRenderingContext.cpp (right):

https://codereview.chromium.org/150083005/diff/1/Source/core/html/canvas/WebG...
Source/core/html/canvas/WebGLRenderingContext.cpp:3325: return internalformat;
There aren't any queries whose results need to be fixed up in the opposite
direction?

[oetuaho-nv, 2014-02-12 12:45:36]

https://codereview.chromium.org/150083005/diff/1/Source/core/html/canvas/WebG...
File Source/core/html/canvas/WebGLRenderingContext.cpp (right):

https://codereview.chromium.org/150083005/diff/1/Source/core/html/canvas/WebG...
Source/core/html/canvas/WebGLRenderingContext.cpp:3325: return internalformat;
On 2014/02/11 23:46:52, Ken Russell wrote:
> There aren't any queries whose results need to be fixed up in the opposite
> direction?

I couldn't find any other calls where conversions should be needed by looking
through the API.

[oetuaho-nv, 2014-02-12 15:17:40]

The CQ bit was checked by oetuaho@nvidia.com

[commit-bot: I haz the power, 2014-02-12 15:17:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oetuaho@nvidia.com/150083005/1

[commit-bot: I haz the power, 2014-02-12 15:26:32]

Change committed as 167013