Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 1500513003: Revert of CC Animations: Make sure that HtmlViewer uses compositor-animation-timelines (Closed)

Created:
5 years ago by battre
Modified:
5 years ago
Reviewers:
loyso (OOO), sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of CC Animations: Make sure that HtmlViewer uses compositor-animation-timelines (patchset #2 id:20001 of https://codereview.chromium.org/1481343002/ ) Reason for revert: Revert because WebViewTest.CanGoBackAndForward and WebViewTest.NavigationClearsForward started failing. Original issue's description: > CC Animations: Make sure that HtmlViewer uses compositor-animation-timelines > > In general, we want to enable external animation system for blink here: https://codereview.chromium.org/1308053006/ > > Make sure that HtmlViewer always uses the new animation system for CC and Blink (cc::AnimationHost). > > Eventually, we will delete LayerSettings everywhere. > > BUG=394777 > > Committed: https://crrev.com/7f32365dc607c8db0d211e67ef71d2f0fa3dbd3b > Cr-Commit-Position: refs/heads/master@{#362911} TBR=sky@chromium.org,loyso@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=394777 Committed: https://crrev.com/04432ee550eb1dfb532a361f5a99d57a33730663 Cr-Commit-Position: refs/heads/master@{#362951}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M components/html_viewer/global_state.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M components/html_viewer/web_layer_tree_view_impl.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
battre
Created Revert of CC Animations: Make sure that HtmlViewer uses compositor-animation-timelines
5 years ago (2015-12-03 10:59:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1500513003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1500513003/1
5 years ago (2015-12-03 11:00:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1500513003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1500513003/1
5 years ago (2015-12-03 11:02:45 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-03 11:03:48 UTC) #4
commit-bot: I haz the power
5 years ago (2015-12-03 11:04:30 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/04432ee550eb1dfb532a361f5a99d57a33730663
Cr-Commit-Position: refs/heads/master@{#362951}

Powered by Google App Engine
This is Rietveld 408576698