add encodeData() to SkImageEncoder, and add encoding to SkImage

add encodeData() to SkImageEncoder, and add encoding to SkImage

BUG=
R=scroggo@google.com

Committed: https://code.google.com/p/skia/source/detail?r=9193

[scroggo, 2013-05-16 17:34:41]

https://codereview.chromium.org/15002004/diff/1/include/core/SkImage.h
File include/core/SkImage.h (right):

https://codereview.chromium.org/15002004/diff/1/include/core/SkImage.h#newcode86
include/core/SkImage.h:86: kPNG_EncodeType,
Any reason we don't support all types in SkImageEncoder?

https://codereview.chromium.org/15002004/diff/1/include/images/SkImageEncoder.h
File include/images/SkImageEncoder.h (right):

https://codereview.chromium.org/15002004/diff/1/include/images/SkImageEncoder...
include/images/SkImageEncoder.h:40: * file 'file', at quality level 'quality'
(which can be in range
This comment is no longer correct. It does not write the results to a file.

[reed1, 2013-05-16 17:55:02]

https://codereview.chromium.org/15002004/diff/1/include/core/SkImage.h
File include/core/SkImage.h (right):

https://codereview.chromium.org/15002004/diff/1/include/core/SkImage.h#newcode86
include/core/SkImage.h:86: kPNG_EncodeType,
On 2013/05/16 17:34:41, scroggo wrote:
> Any reason we don't support all types in SkImageEncoder?

Laziness. At first I tried to include SkImageEncoder.h and use its types
directly, but ran into lots of hurt. I'll add more types.

Why the heck can't we take a string or something, so we don't need an enum that
might not reflect new codecs...

https://codereview.chromium.org/15002004/diff/1/include/images/SkImageEncoder.h
File include/images/SkImageEncoder.h (right):

https://codereview.chromium.org/15002004/diff/1/include/images/SkImageEncoder...
include/images/SkImageEncoder.h:40: * file 'file', at quality level 'quality'
(which can be in range
On 2013/05/16 17:34:41, scroggo wrote:
> This comment is no longer correct. It does not write the results to a file.

Done.

[scroggo, 2013-05-16 17:58:26]

lgtm

https://codereview.chromium.org/15002004/diff/4001/src/image/SkImage.cpp
File src/image/SkImage.cpp (right):

https://codereview.chromium.org/15002004/diff/4001/src/image/SkImage.cpp#newc...
src/image/SkImage.cpp:63: }
Minor nit: if asIB fails, shouldn't we break from the loop?

[scroggo, 2013-05-16 17:58:54]

https://codereview.chromium.org/15002004/diff/4001/src/image/SkImage.cpp
File src/image/SkImage.cpp (right):

https://codereview.chromium.org/15002004/diff/4001/src/image/SkImage.cpp#newc...
src/image/SkImage.cpp:63: }
On 2013/05/16 17:58:26, scroggo wrote:
> Minor nit: if asIB fails, shouldn't we break from the loop?

s/asIB/getROPixels/g

[reed1, 2013-05-16 18:01:41]

https://codereview.chromium.org/15002004/diff/4001/src/image/SkImage.cpp
File src/image/SkImage.cpp (right):

https://codereview.chromium.org/15002004/diff/4001/src/image/SkImage.cpp#newc...
src/image/SkImage.cpp:63: }
On 2013/05/16 17:58:26, scroggo wrote:
> Minor nit: if asIB fails, shouldn't we break from the loop?

Not a nit, but a bug! We should only try one type... Done.

[scroggo, 2013-05-16 18:12:11]

lgtm

[reed1, 2013-05-20 16:33:48]

Committed patchset #4 manually as r9193 (presubmit successful).