Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 1500033003: Revert of Fix TSAN error in skia/chromium ref count debug checks (Closed)

Created:
5 years ago by jam
Modified:
5 years ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix TSAN error in skia/chromium ref count debug checks (patchset #1 id:1 of https://codereview.chromium.org/1494633002/ ) Reason for revert: Broke https://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20%28dbg%29/builds/96882/steps/compile/logs/stdio Looks like analyze didn't do any compiles because sk_ref_cnt_ext_debug.h is not in any build files. Please ensure sk_ref_cnt_ext_debug.h is listed in gyp and build.gn files, otherwise analyze won't know to build any targets when that file changes. Original issue's description: > Fix TSAN error in skia/chromium ref count debug checks > > Using std::atomic to make debug checks thread safe. > > BUG=509693 > R=senorblanco@chromium.org > > Committed: https://crrev.com/0d030275667855c06be6cfc2ac10fb434d7ed771 > Cr-Commit-Position: refs/heads/master@{#363274} TBR=senorblanco@chromium.org,junov@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=509693 Committed: https://crrev.com/4e9a0f74389e0745855d939ac9ef900fbaa68fec Cr-Commit-Position: refs/heads/master@{#363277}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M skia/config/sk_ref_cnt_ext_debug.h View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
jam
Created Revert of Fix TSAN error in skia/chromium ref count debug checks
5 years ago (2015-12-04 20:05:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1500033003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1500033003/1
5 years ago (2015-12-04 20:05:53 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-04 20:09:17 UTC) #4
commit-bot: I haz the power
5 years ago (2015-12-04 20:10:04 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4e9a0f74389e0745855d939ac9ef900fbaa68fec
Cr-Commit-Position: refs/heads/master@{#363277}

Powered by Google App Engine
This is Rietveld 408576698