Issue 150003010: Log gclient revert exceptions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 150003010: Log gclient revert exceptions (Closed)

Created:
6 years, 10 months ago by zty

Modified:
6 years, 10 months ago

Reviewers:
iannucci

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Visibility:
Public.

More Reviews

Description

Log gclient revert exceptions BUG=336460 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=250904

Patch Set 2 : Keep the finally in respond to codereview #

Patch Set 3 : Re-raise exception #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	gclient_scm.py	View	1 2	2 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

iannucci

https://codereview.chromium.org/150003010/diff/1/gclient_scm.py File gclient_scm.py (right): https://codereview.chromium.org/150003010/diff/1/gclient_scm.py#newcode841 gclient_scm.py:841: if os.listdir(tmp_dir): keep the finally add a traceback.print_exc()

6 years, 10 months ago (2014-02-13 00:12:30 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zty@chromium.org/150003010/90001

6 years, 10 months ago (2014-02-13 01:43:53 UTC) #7

Message was sent while issue was closed.

Change committed as 250904