gclient_scm.py - Issue 150003010: Log gclient revert exceptions - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(80)

My Issues | Starred Open | Closed | All

Unified Diff: gclient_scm.py

Issue 150003010: Log gclient revert exceptions (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: Re-raise exception Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gclient_scm.py

diff --git a/gclient_scm.py b/gclient_scm.py

index 2a15abe5f810357d94dc68b58f5df181ff9576eb..71298cc9e9c4e3c9ae5abbbe340a918bd76b580e 100644

--- a/gclient_scm.py

+++ b/gclient_scm.py

@@ -13,6 +13,7 @@ import sys

import tempfile

import threading

import time

+import traceback

import urlparse

import download_from_google_storage

@@ -835,6 +836,9 @@ class GitWrapper(SCMWrapper):

gclient_utils.safe_makedirs(self.checkout_path)

gclient_utils.safe_rename(os.path.join(tmp_dir, '.git'),

os.path.join(self.checkout_path, '.git'))

+ except:

+ traceback.print_exc(file=sys.stderr)

+ raise

finally:

if os.listdir(tmp_dir):

print('\n_____ removing non-empty tmp dir %s' % tmp_dir)

« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698