Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 149993003: IDL compiler: [Custom=PropertyEnumerator] (Closed)

Created:
6 years, 10 months ago by Nils Barth (inactive)
Modified:
6 years, 10 months ago
Reviewers:
haraken
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, ed+blinkwatch_opera.com, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, darktears, Nate Chapin, watchdog-blink-watchlist_google.com, Inactive, kouhei (in TOK)
Visibility:
Public.

Description

IDL compiler: [Custom=PropertyEnumerator] The meat of the CL is simple (just add another 2 boolean flags), but there's some reorganization: * Explicitly distinguish [Custom=PropertyEnumerator] vs. [Custom=PropertyQuery] (currently both lumped together, which makes the treatment of query weird) * Fix order, so consistently getter, setter, query, deleter, enumerator (Matching V8 api.cc SetNamedPropertyHandler) BUG=239771 R=haraken Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166122

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -71 lines) Patch
M Source/bindings/IDLExtendedAttributes.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/scripts/code_generator_v8.pm View 5 chunks +16 lines, -7 lines 1 comment Download
M Source/bindings/scripts/unstable/v8_interface.py View 2 chunks +9 lines, -2 lines 0 comments Download
M Source/bindings/templates/interface.h View 1 chunk +9 lines, -0 lines 0 comments Download
M Source/bindings/templates/interface.cpp View 4 chunks +30 lines, -4 lines 0 comments Download
M Source/bindings/templates/interface_base.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M Source/bindings/tests/idls/TestSpecialOperationsCustom.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestEventTarget.cpp View 2 chunks +16 lines, -16 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsAnonymous.cpp View 2 chunks +16 lines, -16 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsCustom.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsCustom.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsIdentifier.cpp View 2 chunks +16 lines, -16 lines 0 comments Download
M Source/core/css/CSSStyleDeclaration.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Nils Barth (inactive)
https://codereview.chromium.org/149993003/diff/1/Source/bindings/scripts/code_generator_v8.pm File Source/bindings/scripts/code_generator_v8.pm (right): https://codereview.chromium.org/149993003/diff/1/Source/bindings/scripts/code_generator_v8.pm#newcode1104 Source/bindings/scripts/code_generator_v8.pm:1104: my $hasCustomNamedEnumerator = $namedEnumeratorFunction && ExtendedAttributeContains($namedGetterFunction->extendedAttributes->{"Custom"}, "PropertyEnumerator"); Typo fix: ...
6 years, 10 months ago (2014-01-30 04:42:40 UTC) #1
haraken
LGTM
6 years, 10 months ago (2014-01-30 04:49:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/149993003/1
6 years, 10 months ago (2014-01-30 10:07:26 UTC) #3
commit-bot: I haz the power
Change committed as 166122
6 years, 10 months ago (2014-01-30 11:54:33 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-01-30 11:54:34 UTC) #5
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698