Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Unified Diff: Source/bindings/templates/interface.cpp

Issue 149993003: IDL compiler: [Custom=PropertyEnumerator] (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/templates/interface.cpp
diff --git a/Source/bindings/templates/interface.cpp b/Source/bindings/templates/interface.cpp
index 96c0f91cf4e2cc53630c29d9bef86a6d1a57fbc2..7def609c24a65a716bcc72397292eea7cfc07931 100644
--- a/Source/bindings/templates/interface.cpp
+++ b/Source/bindings/templates/interface.cpp
@@ -300,8 +300,9 @@ static void namedPropertySetterCallback(v8::Local<v8::String> name, v8::Local<v8
{##############################################################################}
-{% block named_property_query_and_callback %}
-{% if named_property_getter %}
+{% block named_property_query %}
+{% if named_property_getter and
+ not named_property_getter.is_custom_property_query %}
static void namedPropertyQuery(v8::Local<v8::String> name, const v8::PropertyCallbackInfo<v8::Integer>& info)
{
{{cpp_class}}* collection = {{v8_class}}::toNative(info.Holder());
@@ -315,10 +316,22 @@ static void namedPropertyQuery(v8::Local<v8::String> name, const v8::PropertyCal
v8SetReturnValueInt(info, v8::None);
}
+{% endif %}
+{% endblock %}
+
+
+{##############################################################################}
+{% block named_property_query_callback %}
+{% if named_property_getter %}
+{% set getter = named_property_getter %}
static void namedPropertyQueryCallback(v8::Local<v8::String> name, const v8::PropertyCallbackInfo<v8::Integer>& info)
{
TRACE_EVENT_SET_SAMPLING_STATE("Blink", "DOMNamedProperty");
+ {% if getter.is_custom_property_query %}
+ {{v8_class}}::namedPropertyQueryCustom(name, info);
+ {% else %}
{{cpp_class}}V8Internal::namedPropertyQuery(name, info);
+ {% endif %}
TRACE_EVENT_SET_SAMPLING_STATE("V8", "V8Execution");
}
@@ -364,8 +377,9 @@ static void namedPropertyDeleterCallback(v8::Local<v8::String> name, const v8::P
{##############################################################################}
-{% block named_property_enumerator_and_callback %}
-{% if named_property_getter %}
+{% block named_property_enumerator %}
+{% if named_property_getter and
+ not named_property_getter.is_custom_property_enumerator %}
static void namedPropertyEnumerator(const v8::PropertyCallbackInfo<v8::Array>& info)
{
ExceptionState exceptionState(info.Holder(), info.GetIsolate());
@@ -380,10 +394,22 @@ static void namedPropertyEnumerator(const v8::PropertyCallbackInfo<v8::Array>& i
v8SetReturnValue(info, v8names);
}
+{% endif %}
+{% endblock %}
+
+
+{##############################################################################}
+{% block named_property_enumerator_callback %}
+{% if named_property_getter %}
+{% set getter = named_property_getter %}
static void namedPropertyEnumeratorCallback(const v8::PropertyCallbackInfo<v8::Array>& info)
{
TRACE_EVENT_SET_SAMPLING_STATE("Blink", "DOMNamedProperty");
+ {% if getter.is_custom_property_enumerator %}
+ {{v8_class}}::namedPropertyEnumeratorCustom(info);
+ {% else %}
{{cpp_class}}V8Internal::namedPropertyEnumerator(info);
+ {% endif %}
TRACE_EVENT_SET_SAMPLING_STATE("V8", "V8Execution");
}

Powered by Google App Engine
This is Rietveld 408576698