Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 149993002: Revert 247772 "Cache feedback reports to disk in case of send fa..." (Closed)

Created:
6 years, 10 months ago by benwells
Modified:
6 years, 10 months ago
Reviewers:
rkc
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 247772 "Cache feedback reports to disk in case of send fa..." > Cache feedback reports to disk in case of send failure. > > R=zork@chromium.org > BUG=249853 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246992 > > Review URL: https://codereview.chromium.org/141433011 This introduced a race condition picked up by the TSAN bots. BUG=339326 TBR=rkc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247816

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -327 lines) Patch
M trunk/src/chrome/browser/chrome_browser_main.cc View 2 chunks +0 lines, -5 lines 0 comments Download
D trunk/src/chrome/browser/feedback/feedback_profile_observer.h View 1 chunk +0 lines, -50 lines 0 comments Download
D trunk/src/chrome/browser/feedback/feedback_profile_observer.cc View 1 chunk +0 lines, -60 lines 0 comments Download
D trunk/src/chrome/browser/feedback/feedback_report.h View 1 chunk +0 lines, -63 lines 0 comments Download
D trunk/src/chrome/browser/feedback/feedback_report.cc View 1 chunk +0 lines, -91 lines 0 comments Download
M trunk/src/chrome/browser/feedback/feedback_uploader.h View 3 chunks +9 lines, -12 lines 0 comments Download
M trunk/src/chrome/browser/feedback/feedback_uploader.cc View 5 chunks +39 lines, -19 lines 0 comments Download
M trunk/src/chrome/browser/feedback/feedback_uploader_delegate.h View 2 chunks +4 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/feedback/feedback_uploader_delegate.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/feedback/feedback_uploader_unittest.cc View 3 chunks +8 lines, -14 lines 0 comments Download
M trunk/src/chrome/browser/feedback/feedback_util.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M trunk/src/chrome/chrome_browser.gypi View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
benwells
6 years, 10 months ago (2014-01-30 03:34:03 UTC) #1
benwells
6 years, 10 months ago (2014-01-30 03:34:23 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r247816.

Powered by Google App Engine
This is Rietveld 408576698