Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Unified Diff: trunk/src/chrome/browser/feedback/feedback_uploader_unittest.cc

Issue 149993002: Revert 247772 "Cache feedback reports to disk in case of send fa..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/browser/feedback/feedback_uploader_unittest.cc
===================================================================
--- trunk/src/chrome/browser/feedback/feedback_uploader_unittest.cc (revision 247814)
+++ trunk/src/chrome/browser/feedback/feedback_uploader_unittest.cc (working copy)
@@ -54,15 +54,15 @@
}
void QueueReport(const std::string& data) {
- uploader_->QueueReport(data);
+ uploader_->QueueReport(make_scoped_ptr(new std::string(data)));
}
void ReportFailure(const std::string& data) {
- uploader_->RetryReport(data);
+ uploader_->RetryReport(make_scoped_ptr(new std::string(data)));
}
- void MockDispatchReport(const std::string& report_data) {
- dispatched_reports_.push_back(report_data);
+ void MockDispatchReport(scoped_ptr<std::string> report_data) {
+ dispatched_reports_.push_back(*report_data.get());
// Dispatch will always update the timer, whether successful or not,
// simulate the same behavior.
@@ -90,13 +90,7 @@
size_t expected_reports_;
};
-#if defined(OS_LINUX) || defined(OS_CHROMEOS) || defined(OS_MACOSX)
-#define MAYBE_QueueMultiple QueueMultiple
-#else
-// crbug.com/330547
-#define MAYBE_QueueMultiple DISABLED_QueueMultiple
-#endif
-TEST_F(FeedbackUploaderTest, MAYBE_QueueMultiple) {
+TEST_F(FeedbackUploaderTest, QueueMultiple) {
dispatched_reports_.clear();
QueueReport(kReportOne);
QueueReport(kReportTwo);
@@ -110,11 +104,11 @@
EXPECT_EQ(dispatched_reports_[3], kReportFour);
}
-#if defined(OS_LINUX) || defined(OS_CHROMEOS) || defined(OS_MACOSX)
-#define MAYBE_QueueMultipleWithFailures QueueMultipleWithFailures
-#else
+#if defined(OS_WIN)
// crbug.com/330547
#define MAYBE_QueueMultipleWithFailures DISABLED_QueueMultipleWithFailures
+#else
+#define MAYBE_QueueMultipleWithFailures QueueMultipleWithFailures
#endif
TEST_F(FeedbackUploaderTest, MAYBE_QueueMultipleWithFailures) {
dispatched_reports_.clear();
« no previous file with comments | « trunk/src/chrome/browser/feedback/feedback_uploader_delegate.cc ('k') | trunk/src/chrome/browser/feedback/feedback_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698