Issue 1499763002: Reapply "Precompilation/x64: Load float vector constants via Thread."

Issue 1499763002: Reapply "Precompilation/x64: Load float vector constants via Thread." (Closed)

Created:
5 years ago by rmacnak

Modified:
5 years ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Reapply "Precompilation/x64: Load float vector constants via Thread." Fix unbalanced Enter/LeaveTestFrame in TestObjectCompare. Crashed on release + clang with the original change, and was failing on ASAN before that. BUG=http://dartbug.com/24450 BUG=http://dartbug.com/25002 R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/3e7212e194490c52a775570464c21b0d80df952a

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+132 lines, -122 lines)			Patch
M	runtime/tests/vm/vm.status	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	runtime/vm/assembler_arm64_test.cc	View	10 chunks	+13 lines, -26 lines	0 comments	Download
M	runtime/vm/assembler_x64.cc	View	4 chunks	+16 lines, -64 lines	0 comments	Download
M	runtime/vm/assembler_x64_test.cc	View	11 chunks	+21 lines, -14 lines	0 comments	Download
M	runtime/vm/thread.h	View	2 chunks	+12 lines, -2 lines	0 comments	Download
M	runtime/vm/thread.cc	View	1 chunk	+45 lines, -0 lines	0 comments	Download
M	runtime/vm/unit_test.h	View	2 chunks	+25 lines, -13 lines	0 comments	Download

Total messages: 5 (2 generated)

rmacnak

5 years ago (2015-12-04 17:46:25 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3e7212e194490c52a775570464c21b0d80df952a (presubmit successful).