Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 1499453002: Create a define for nanobench builds to dump stats (Closed)

Created:
5 years ago by joshua.litt
Modified:
5 years ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Create a define for nanobench builds to dump stats TBR=bsalomon@google.com BUG=skia: Committed: https://skia.googlesource.com/skia/+/f16f88b779f802bb3c9892e6f1275fe980e956a1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M gyp/common_conditions.gypi View 1 chunk +5 lines, -0 lines 0 comments Download
M gyp/common_variables.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M include/gpu/GrConfig.h View 2 chunks +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (7 generated)
joshualitt
ptal, a minimal change
5 years ago (2015-12-02 20:34:37 UTC) #2
robertphillips
lgtm
5 years ago (2015-12-02 20:38:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1499453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1499453002/1
5 years ago (2015-12-02 20:47:35 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/4343)
5 years ago (2015-12-02 20:49:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1499453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1499453002/1
5 years ago (2015-12-02 20:52:58 UTC) #11
commit-bot: I haz the power
5 years ago (2015-12-02 21:00:40 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f16f88b779f802bb3c9892e6f1275fe980e956a1

Powered by Google App Engine
This is Rietveld 408576698