Wire up new define in buildbot_spec

Wire up new define in buildbot_spec

NOPRESUBMIT=True
NOTRY=True
BUG=skia:

[joshualitt, 2015-12-02 20:47:38]

joshualitt@google.com changed reviewers:
+ borenet@google.com, joshualitt@google.com

[joshualitt, 2015-12-02 20:47:38]

ptal

[borenet, 2015-12-02 20:50:42]

https://codereview.chromium.org/1492133002/diff/1/tools/buildbot_spec.py
File tools/buildbot_spec.py (right):

https://codereview.chromium.org/1492133002/diff/1/tools/buildbot_spec.py#newc...
tools/buildbot_spec.py:152: builder_dict['role'] in ('Perf')):
Can just say:

builder_dict['role'] == 'Perf'

https://codereview.chromium.org/1492133002/diff/1/tools/buildbot_spec.py#newc...
tools/buildbot_spec.py:153: gyp_defs['skia_dump_stats'] = '1'
Did you add this to the gyp files?

[joshualitt, 2015-12-02 21:25:35]

joshualitt@google.com changed reviewers:
+ stephana@google.com

[joshualitt, 2015-12-02 21:25:36]

Adding Stephan for expedited review.

[stephana, 2015-12-02 21:46:56]

https://codereview.chromium.org/1492133002/diff/1/tools/buildbot_spec.py
File tools/buildbot_spec.py (right):

https://codereview.chromium.org/1492133002/diff/1/tools/buildbot_spec.py#newc...
tools/buildbot_spec.py:152: builder_dict['role'] in ('Perf')):
On 2015/12/02 20:50:42, borenet wrote:
> Can just say:
> 
> builder_dict['role'] == 'Perf'

builder_dict.get('role') == 'Perf'
Get will not crash if 'role' is not in the dict.

[joshualitt, 2015-12-02 21:49:32]

On 2015/12/02 21:46:56, stephana wrote:
> https://codereview.chromium.org/1492133002/diff/1/tools/buildbot_spec.py
> File tools/buildbot_spec.py (right):
> 
>
https://codereview.chromium.org/1492133002/diff/1/tools/buildbot_spec.py#newc...
> tools/buildbot_spec.py:152: builder_dict['role'] in ('Perf')):
> On 2015/12/02 20:50:42, borenet wrote:
> > Can just say:
> > 
> > builder_dict['role'] == 'Perf'
> 
> builder_dict.get('role') == 'Perf'
> Get will not crash if 'role' is not in the dict.

feedback inc

[joshualitt, 2015-12-02 21:50:05]

https://codereview.chromium.org/1492133002/diff/1/tools/buildbot_spec.py
File tools/buildbot_spec.py (right):

https://codereview.chromium.org/1492133002/diff/1/tools/buildbot_spec.py#newc...
tools/buildbot_spec.py:153: gyp_defs['skia_dump_stats'] = '1'
On 2015/12/02 20:50:42, borenet wrote:
> Did you add this to the gyp files?

yes, I just added it to the gyp file in a previous cl.

[stephana, 2015-12-02 21:51:16]

On 2015/12/02 21:49:32, joshualitt wrote:
> On 2015/12/02 21:46:56, stephana wrote:
> > https://codereview.chromium.org/1492133002/diff/1/tools/buildbot_spec.py
> > File tools/buildbot_spec.py (right):
> > 
> >
>
https://codereview.chromium.org/1492133002/diff/1/tools/buildbot_spec.py#newc...
> > tools/buildbot_spec.py:152: builder_dict['role'] in ('Perf')):
> > On 2015/12/02 20:50:42, borenet wrote:
> > > Can just say:
> > > 
> > > builder_dict['role'] == 'Perf'
> > 
> > builder_dict.get('role') == 'Perf'
> > Get will not crash if 'role' is not in the dict.
> 
> feedback inc

lgtm

[joshualitt, 2015-12-02 21:51:30]

The CQ bit was checked by joshualitt@google.com

[commit-bot: I haz the power, 2015-12-02 21:51:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1492133002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1492133002/40001

[commit-bot: I haz the power, 2015-12-02 22:06:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-02 22:06:13]

Failed to apply the patch.

[commit-bot: I haz the power, 2015-12-02 22:07:23]

The CQ bit was unchecked by commit-bot@chromium.org

[borenet, 2015-12-03 12:31:50]

LGTM

https://codereview.chromium.org/1492133002/diff/1/tools/buildbot_spec.py
File tools/buildbot_spec.py (right):

https://codereview.chromium.org/1492133002/diff/1/tools/buildbot_spec.py#newc...
tools/buildbot_spec.py:152: builder_dict['role'] in ('Perf')):
On 2015/12/02 21:46:56, stephana wrote:
> On 2015/12/02 20:50:42, borenet wrote:
> > Can just say:
> > 
> > builder_dict['role'] == 'Perf'
> 
> builder_dict.get('role') == 'Perf'
> Get will not crash if 'role' is not in the dict. 

True, but not necessary in this case since all bots have a role (it's what
defines what other properties they have).

[joshualitt, 2015-12-03 14:28:41]

The CQ bit was checked by joshualitt@google.com

[joshualitt, 2015-12-03 14:28:41]

The patchset sent to the CQ was uploaded after l-g-t-m from stephana@google.com
Link to the patchset: https://codereview.chromium.org/1492133002/#ps60001
(title: "actually wire up")

[commit-bot: I haz the power, 2015-12-03 14:28:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1492133002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1492133002/60001

[commit-bot: I haz the power, 2015-12-03 14:29:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-03 14:29:52]

Try jobs failed on following builders:
  skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[joshualitt, 2015-12-03 14:50:44]

Description was changed from

==========
Wire up new define in buildbot_spec

BUG=skia:
==========

to

==========
Wire up new define in buildbot_spec

NOTRY=True
BUG=skia:
==========

[joshualitt, 2015-12-03 14:50:52]

The CQ bit was checked by joshualitt@google.com

[commit-bot: I haz the power, 2015-12-03 14:50:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1492133002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1492133002/60001

[commit-bot: I haz the power, 2015-12-03 14:51:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-03 14:51:47]

Try jobs failed on following builders:
  skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[joshualitt, 2015-12-03 14:53:37]

Description was changed from

==========
Wire up new define in buildbot_spec

NOTRY=True
BUG=skia:
==========

to

==========
Wire up new define in buildbot_spec

NOPRESUBMIT=True
NOTRY=True
BUG=skia:
==========

[joshualitt, 2015-12-03 14:53:42]

The CQ bit was checked by joshualitt@google.com

[commit-bot: I haz the power, 2015-12-03 14:53:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1492133002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1492133002/60001

[commit-bot: I haz the power, 2015-12-03 17:15:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-03 17:15:38]

Failed to apply the patch.

[commit-bot: I haz the power, 2015-12-03 17:15:39]

The CQ bit was unchecked by commit-bot@chromium.org

[jcgregorio, 2015-12-04 19:06:18]

On 2015/12/03 at 17:15:38, commit-bot wrote:
> Failed to apply the patch.

For future reference please CC me on CLs that will change the amount of data
that goes into perf. Between this CL and
https://codereview.chromium.org/1495543003 the amount of data sent to Perf just
increased by 6x.