Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3557)

Unified Diff: chrome/browser/download/download_query_unittest.cc

Issue 1499423004: Remove kint32max. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@kint9
Patch Set: rebase Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/strings/string_util.cc ('k') | chrome/browser/extensions/api/messaging/message_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/download_query_unittest.cc
diff --git a/chrome/browser/download/download_query_unittest.cc b/chrome/browser/download/download_query_unittest.cc
index a5a9a1bec643707d22c4d8290b198d6ae9593576..6947055a81261f3396f6821776f6078f03d726fd 100644
--- a/chrome/browser/download/download_query_unittest.cc
+++ b/chrome/browser/download/download_query_unittest.cc
@@ -2,6 +2,9 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#include <stdint.h>
+
+#include <limits>
#include <string>
#include "base/bind.h"
@@ -31,7 +34,7 @@ static const int kSomeKnownTime = 1355864160;
static const char kSomeKnownTime8601[] = "2012-12-18T20:56:0";
static const char k8601Suffix[] = ".000Z";
-bool IdNotEqual(uint32 not_id, const DownloadItem& item) {
+bool IdNotEqual(uint32_t not_id, const DownloadItem& item) {
return item.GetId() != not_id;
}
@@ -157,9 +160,9 @@ TEST_F(DownloadQueryTest, DownloadQueryTest_ZeroItems) {
TEST_F(DownloadQueryTest, DownloadQueryTest_InvalidFilter) {
scoped_ptr<base::Value> value(new base::FundamentalValue(0));
- EXPECT_FALSE(query()->AddFilter(
- static_cast<DownloadQuery::FilterType>(kint32max),
- *value.get()));
+ EXPECT_FALSE(query()->AddFilter(static_cast<DownloadQuery::FilterType>(
+ std::numeric_limits<int32_t>::max()),
+ *value.get()));
}
TEST_F(DownloadQueryTest, DownloadQueryTest_EmptyQuery) {
« no previous file with comments | « base/strings/string_util.cc ('k') | chrome/browser/extensions/api/messaging/message_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698