ppapi/shared_impl/id_assignment.cc - Issue 1499423004: Remove kint32max.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/shared_impl/id_assignment.cc

Issue 1499423004: Remove kint32max. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@kint9

Patch Set: rebase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ppapi/shared_impl/id_assignment.cc

diff --git a/ppapi/shared_impl/id_assignment.cc b/ppapi/shared_impl/id_assignment.cc

index 5c5aed6b82271e5795eff0e55baeafb70419ad56..b1120e9c2b8d4652776d4610afebf40012a05263 100644

--- a/ppapi/shared_impl/id_assignment.cc

+++ b/ppapi/shared_impl/id_assignment.cc

@@ -4,13 +4,13 @@

#include "ppapi/shared_impl/id_assignment.h"

-#include "base/basictypes.h"

+#include <stdint.h>

namespace ppapi {

const unsigned int kPPIdTypeBits = 2;

-const int32 kMaxPPId = kint32max >> kPPIdTypeBits;

+const int32_t kMaxPPId = INT32_MAX >> kPPIdTypeBits;

raymes 2015/12/06 23:16:34 Hmm why not use numeric_limits here?

Avi (use Gerrit) 2015/12/06 23:50:29 Because that's not guaranteed to be constexpr, and

static_assert(PP_ID_TYPE_COUNT <= (1 << kPPIdTypeBits),

"kPPIdTypeBits is too small for all id types");