Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Unified Diff: chrome/app/android/chrome_data_reduction_proxy_android.h

Issue 14994003: Remove round trip from data reduction proxy authentication (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added data reduction proxy initialization logic Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/app/android/chrome_data_reduction_proxy_android.h
diff --git a/chrome/app/android/chrome_data_reduction_proxy_android.h b/chrome/app/android/chrome_data_reduction_proxy_android.h
new file mode 100644
index 0000000000000000000000000000000000000000..92f000c278a22efa9468daa617a71cded4316b89
--- /dev/null
+++ b/chrome/app/android/chrome_data_reduction_proxy_android.h
@@ -0,0 +1,25 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
Yaron 2013/05/21 18:04:30 I believe no "(c)" is the new hawtness
bengr 2013/05/22 19:03:15 Done.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_APP_ANDROID_CHROME_DATA_REDUCTION_PROXY_ANDROID_H_
+#define CHROME_APP_ANDROID_CHROME_DATA_REDUCTION_PROXY_ANDROID_H_
+
+#include "net/http/http_network_session.h"
+
+class ChromeDataReductionProxyAndroid {
Yaron 2013/05/21 18:04:30 Brief comment please
bengr 2013/05/22 19:03:15 Done.
+ public:
+ static ChromeDataReductionProxyAndroid* Create();
+
+ virtual void Init(net::HttpNetworkSession* session) const;
Yaron 2013/05/21 18:04:30 I think you can just make this pure virtual (i.e.
bengr 2013/05/22 19:03:15 Done.
+
+ virtual ~ChromeDataReductionProxyAndroid();
+
+ protected:
+ ChromeDataReductionProxyAndroid();
+
Yaron 2013/05/21 18:04:30 nit: extra ws line
bengr 2013/05/22 19:03:15 Done.
+
+ DISALLOW_COPY_AND_ASSIGN(ChromeDataReductionProxyAndroid);
+};
+
+#endif // CHROME_APP_ANDROID_CHROME_DATA_REDUCTION_PROXY_ANDROID_H_

Powered by Google App Engine
This is Rietveld 408576698