chrome/app/android/chrome_data_reduction_proxy_android.h - Issue 14994003: Remove round trip from data reduction proxy authentication

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/app/android/chrome_data_reduction_proxy_android.h

Issue 14994003: Remove round trip from data reduction proxy authentication (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Added data reduction proxy initialization logic Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/android/testshell/chrome_data_reduction_proxy_testshell_android.h ('K') | « chrome/android/testshell/chrome_data_reduction_proxy_testshell_android.cc ('k') | chrome/app/android/chrome_data_reduction_proxy_android.cc » ('j') | chrome/app/android/chrome_data_reduction_proxy_android.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
	Yaron 2013/05/21 18:04:30 I believe no "(c)" is the new hawtness I believe no "(c)" is the new hawtness bengr 2013/05/22 19:03:15 Done. Show quoted text On 2013/05/21 18:04:30, Yaron wrote: > I believe no "(c)" is the new hawtness Done.
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_APP_ANDROID_CHROME_DATA_REDUCTION_PROXY_ANDROID_H_

	6 #define CHROME_APP_ANDROID_CHROME_DATA_REDUCTION_PROXY_ANDROID_H_

	7

	8 #include "net/http/http_network_session.h"

	9

	10 class ChromeDataReductionProxyAndroid {
	Yaron 2013/05/21 18:04:30 Brief comment please Brief comment please bengr 2013/05/22 19:03:15 Done. Show quoted text On 2013/05/21 18:04:30, Yaron wrote: > Brief comment please Done.
	11 public:

	12 static ChromeDataReductionProxyAndroid* Create();

	13

	14 virtual void Init(net::HttpNetworkSession* session) const;
	Yaron 2013/05/21 18:04:30 I think you can just make this pure virtual (i.e. I think you can just make this pure virtual (i.e. = 0) and avoid the definition. bengr 2013/05/22 19:03:15 Done. Show quoted text On 2013/05/21 18:04:30, Yaron wrote: > I think you can just make this pure virtual (i.e. = 0) and avoid the definition. Done.
	15

	16 virtual ~ChromeDataReductionProxyAndroid();

	17

	18 protected:

	19 ChromeDataReductionProxyAndroid();

	20
	Yaron 2013/05/21 18:04:30 nit: extra ws line nit: extra ws line bengr 2013/05/22 19:03:15 Done. Show quoted text On 2013/05/21 18:04:30, Yaron wrote: > nit: extra ws line Done.
	21

	22 DISALLOW_COPY_AND_ASSIGN(ChromeDataReductionProxyAndroid);

	23 };

	24

	25 #endif // CHROME_APP_ANDROID_CHROME_DATA_REDUCTION_PROXY_ANDROID_H_

OLD	NEW