Issue 1499163002: Fix ASAN test failure in QUIC's CryptoHandshakeMessageTest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1499163002: Fix ASAN test failure in QUIC's CryptoHandshakeMessageTest (Closed)

Created:
5 years ago by Jo Kulik

Modified:
5 years ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@108754896

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix ASAN test failure in QUIC's CryptoHandshakeMessageTest. The last argument to SetTagList must be 0. n/a (test only) Merge internal change: 108792500 R=rch@chromium.org BUG=

Patch Set 1 #

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -30 lines)			Patch
M	net/quic/reliable_quic_stream_test.cc	View	2 chunks	+1 line, -11 lines	0 comments	Download
M	net/quic/test_tools/quic_test_utils.h	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	net/quic/test_tools/quic_test_utils.cc	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	net/tools/quic/quic_spdy_server_stream_test.cc	View	6 chunks	+12 lines, -19 lines	0 comments	Download

Depends on Patchset:

Issue 1499153002 Patch 1

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages