Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Unified Diff: net/tools/quic/quic_spdy_server_stream_test.cc

Issue 1499163002: Fix ASAN test failure in QUIC's CryptoHandshakeMessageTest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@108754896
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/test_tools/quic_test_utils.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/quic_spdy_server_stream_test.cc
diff --git a/net/tools/quic/quic_spdy_server_stream_test.cc b/net/tools/quic/quic_spdy_server_stream_test.cc
index 198f39facda4a467fbb5f8fd56d504d9d53f509a..1a3d98851a76b618ef9d84486265e82c91157f9d 100644
--- a/net/tools/quic/quic_spdy_server_stream_test.cc
+++ b/net/tools/quic/quic_spdy_server_stream_test.cc
@@ -130,23 +130,14 @@ class QuicSpdyServerStreamTest : public ::testing::TestWithParam<QuicVersion> {
string body_;
};
-QuicConsumedData ConsumeAllData(
- QuicStreamId /*id*/,
- const QuicIOVector& data,
- QuicStreamOffset /*offset*/,
- bool fin,
- FecProtection /*fec_protection_*/,
- QuicAckListenerInterface* /*ack_notifier_delegate*/) {
- return QuicConsumedData(data.total_length, fin);
-}
-
INSTANTIATE_TEST_CASE_P(Tests,
QuicSpdyServerStreamTest,
::testing::ValuesIn(QuicSupportedVersions()));
TEST_P(QuicSpdyServerStreamTest, TestFraming) {
- EXPECT_CALL(session_, WritevData(_, _, _, _, _, _)).Times(AnyNumber()).
- WillRepeatedly(Invoke(ConsumeAllData));
+ EXPECT_CALL(session_, WritevData(_, _, _, _, _, _))
+ .Times(AnyNumber())
+ .WillRepeatedly(Invoke(MockQuicSpdySession::ConsumeAllData));
stream_->OnStreamHeaders(headers_string_);
stream_->OnStreamHeadersComplete(false, headers_string_.size());
stream_->OnStreamFrame(
@@ -158,8 +149,9 @@ TEST_P(QuicSpdyServerStreamTest, TestFraming) {
}
TEST_P(QuicSpdyServerStreamTest, TestFramingOnePacket) {
- EXPECT_CALL(session_, WritevData(_, _, _, _, _, _)).Times(AnyNumber()).
- WillRepeatedly(Invoke(ConsumeAllData));
+ EXPECT_CALL(session_, WritevData(_, _, _, _, _, _))
+ .Times(AnyNumber())
+ .WillRepeatedly(Invoke(MockQuicSpdySession::ConsumeAllData));
stream_->OnStreamHeaders(headers_string_);
stream_->OnStreamHeadersComplete(false, headers_string_.size());
@@ -174,7 +166,7 @@ TEST_P(QuicSpdyServerStreamTest, TestFramingOnePacket) {
TEST_P(QuicSpdyServerStreamTest, SendQuicRstStreamNoErrorInStopReading) {
EXPECT_CALL(session_, WritevData(_, _, _, _, _, _))
.Times(AnyNumber())
- .WillRepeatedly(Invoke(ConsumeAllData));
+ .WillRepeatedly(Invoke(MockQuicSpdySession::ConsumeAllData));
EXPECT_FALSE(stream_->fin_received());
EXPECT_FALSE(stream_->rst_received());
@@ -194,8 +186,9 @@ TEST_P(QuicSpdyServerStreamTest, TestFramingExtraData) {
string large_body = "hello world!!!!!!";
// We'll automatically write out an error (headers + body)
- EXPECT_CALL(session_, WritevData(_, _, _, _, _, _)).Times(AnyNumber()).
- WillRepeatedly(Invoke(ConsumeAllData));
+ EXPECT_CALL(session_, WritevData(_, _, _, _, _, _))
+ .Times(2)
+ .WillRepeatedly(Invoke(MockQuicSpdySession::ConsumeAllData));
EXPECT_CALL(session_, SendRstStream(_, QUIC_STREAM_NO_ERROR, _)).Times(0);
stream_->OnStreamHeaders(headers_string_);
@@ -328,7 +321,7 @@ TEST_P(QuicSpdyServerStreamTest, InvalidMultipleContentLength) {
EXPECT_CALL(session_, WritevData(_, _, _, _, _, _))
.Times(AnyNumber())
- .WillRepeatedly(Invoke(ConsumeAllData));
+ .WillRepeatedly(Invoke(MockQuicSpdySession::ConsumeAllData));
stream_->OnStreamHeaders(headers_string_);
stream_->OnStreamHeadersComplete(true, headers_string_.size());
@@ -348,7 +341,7 @@ TEST_P(QuicSpdyServerStreamTest, InvalidLeadingNullContentLength) {
EXPECT_CALL(session_, WritevData(_, _, _, _, _, _))
.Times(AnyNumber())
- .WillRepeatedly(Invoke(ConsumeAllData));
+ .WillRepeatedly(Invoke(MockQuicSpdySession::ConsumeAllData));
stream_->OnStreamHeaders(headers_string_);
stream_->OnStreamHeadersComplete(true, headers_string_.size());
« no previous file with comments | « net/quic/test_tools/quic_test_utils.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698