Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: pkg/analyzer/lib/src/services/writer.dart

Issue 149913002: Max line length test fix (dartbug.com/16405). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer/test/services/data/cu_tests.data » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/services/writer.dart
===================================================================
--- pkg/analyzer/lib/src/services/writer.dart (revision 32131)
+++ pkg/analyzer/lib/src/services/writer.dart (working copy)
@@ -232,7 +232,7 @@
}
}
- bool fits(LineText text) => length + text.length < maxLength;
+ bool fits(LineText text) => length + text.length <= maxLength;
int get length => start.value.length + buffer.length;
@@ -257,11 +257,15 @@
String toString() => value;
- int get length => value.length;
+ int get length => lengthLessNewlines(value);
void addTo(Chunk chunk) {
chunk.buffer.write(value);
}
+
+ int lengthLessNewlines(String str) =>
+ str.endsWith('\n') ? str.length - 1 : str.length;
Brian Wilkerson 2014/01/30 00:51:20 Do we also need to test for "\r\n"?
+
}
« no previous file with comments | « no previous file | pkg/analyzer/test/services/data/cu_tests.data » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698