Max line length test fix (dartbug.com/16405).

pkg/analyzer/lib/src/services/writer.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library source_writer;
 
 
 
 class Line {
 
@@ skipping 214 matching lines @@
 
   int maxLength;
   SpaceToken start;
 
   Chunk({this.start, this.maxLength}) {
     if (start == null) {
       start = LINE_START;
     }
   }
 
-  bool fits(LineText text) => length + text.length < maxLength;
+  bool fits(LineText text) => length + text.length <= maxLength;
 
   int get length => start.value.length + buffer.length;
 
   void add(LineText text) {
     text.addTo(this);
   }
 
   String toString() => buffer.toString();
 
   void addTo(Chunk chunk) {
     chunk.buffer.write(start.value);
     chunk.buffer.write(buffer.toString());
   }
 }
 
 
 class LineToken implements LineText {
 
   final String value;
 
   LineToken(this.value);
 
   String toString() => value;
 
-  int get length => value.length;
+  int get length => lengthLessNewlines(value);
 
   void addTo(Chunk chunk) {
     chunk.buffer.write(value);
   }
+
+  int lengthLessNewlines(String str) =>
+      str.endsWith('\n') ? str.length - 1 : str.length;

[Brian Wilkerson, 2014/01/30 00:51:20]

Do we also need to test for "\r\n"?

+
 }
 
 
 class SpaceToken extends LineToken {
 
   final int breakWeight;
 
   SpaceToken(int n, {this.breakWeight: DEFAULT_SPACE_WEIGHT}) :
       super(getSpaces(n));
 }
@@ skipping 138 matching lines @@
 
 String getTabs(int n) => n < TABS.length ? TABS[n] : repeat('\t', n);
 
 String repeat(String ch, int times) {
   var sb = new StringBuffer();
   for (var i = 0; i < times; ++i) {
     sb.write(ch);
   }
   return sb.toString();
 }