|
|
Description[chromedriver] Use instanceof instead of typeof to check if value is an object.
BUG=chromedriver:1276
Committed: https://crrev.com/5b8706ee716ec3ef0d5df3c72a571f28ad4c8428
Cr-Commit-Position: refs/heads/master@{#363412}
Patch Set 1 #Patch Set 2 : use instanceof instead of typeof #Messages
Total messages: 18 (9 generated)
Description was changed from ========== fix brokenness BUG= ========== to ========== [chromedriver] Use instanceof instead of typeof to check if value is an object. BUG=chromedriver:1276 ==========
samuong@chromium.org changed reviewers: + stgao@chromium.org
ptal
lgtm
The CQ bit was checked by samuong@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1499013002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1499013002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL) win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL) win_chromium_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL) win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by samuong@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1499013002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1499013002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL) win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL) win_chromium_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL) win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by gmanikpure@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1499013002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1499013002/20001
Message was sent while issue was closed.
Description was changed from ========== [chromedriver] Use instanceof instead of typeof to check if value is an object. BUG=chromedriver:1276 ========== to ========== [chromedriver] Use instanceof instead of typeof to check if value is an object. BUG=chromedriver:1276 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [chromedriver] Use instanceof instead of typeof to check if value is an object. BUG=chromedriver:1276 ========== to ========== [chromedriver] Use instanceof instead of typeof to check if value is an object. BUG=chromedriver:1276 Committed: https://crrev.com/5b8706ee716ec3ef0d5df3c72a571f28ad4c8428 Cr-Commit-Position: refs/heads/master@{#363412} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/5b8706ee716ec3ef0d5df3c72a571f28ad4c8428 Cr-Commit-Position: refs/heads/master@{#363412} |