Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Issue 1499013002: [chromedriver] Use instanceof instead of typeof to check if value is an object. (Closed)

Created:
5 years ago by samuong
Modified:
5 years ago
Reviewers:
stgao, gmanikpure
CC:
chromium-reviews, samuong+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[chromedriver] Use instanceof instead of typeof to check if value is an object. BUG=chromedriver:1276 Committed: https://crrev.com/5b8706ee716ec3ef0d5df3c72a571f28ad4c8428 Cr-Commit-Position: refs/heads/master@{#363412}

Patch Set 1 #

Patch Set 2 : use instanceof instead of typeof #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/test/chromedriver/js/call_function.js View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
samuong
ptal
5 years ago (2015-12-04 21:06:05 UTC) #3
stgao
lgtm
5 years ago (2015-12-05 00:30:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1499013002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1499013002/20001
5 years ago (2015-12-05 00:36:22 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL) win_chromium_compile_dbg_ng on ...
5 years ago (2015-12-05 02:42:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1499013002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1499013002/20001
5 years ago (2015-12-05 06:39:34 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL) win_chromium_compile_dbg_ng on ...
5 years ago (2015-12-05 08:41:50 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1499013002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1499013002/20001
5 years ago (2015-12-07 06:27:33 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-07 08:00:21 UTC) #16
commit-bot: I haz the power
5 years ago (2015-12-07 08:01:46 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5b8706ee716ec3ef0d5df3c72a571f28ad4c8428
Cr-Commit-Position: refs/heads/master@{#363412}

Powered by Google App Engine
This is Rietveld 408576698