Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 1499003002: extract ReplacementRange for use in tests (Closed)

Created:
5 years ago by danrubel
Modified:
5 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : remove print #

Patch Set 3 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -27 lines) Patch
M pkg/analysis_server/lib/src/services/completion/dart/arglist_contributor.dart View 1 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart View 2 chunks +41 lines, -24 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart View 3 chunks +6 lines, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/dart/keyword_contributor_test.dart View 10 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
danrubel
5 years ago (2015-12-04 00:38:18 UTC) #2
scheglov
lgtm
5 years ago (2015-12-04 00:41:37 UTC) #3
danrubel
5 years ago (2015-12-04 00:42:25 UTC) #4
danrubel
5 years ago (2015-12-04 01:59:34 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
7b5a756b0f65a52ecb03abb6b103ef4406f2eda3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698