Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart

Issue 1499003002: extract ReplacementRange for use in tests (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: merge Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart
diff --git a/pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart b/pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart
index 7794c29552bd599b9bcf7fa1dd184fea40b4f887..869ed882ef556cc5a02a59332214d36be8243373 100644
--- a/pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart
+++ b/pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart
@@ -16,7 +16,7 @@ import 'package:analysis_server/src/services/completion/completion_core.dart';
import 'package:analysis_server/src/services/completion/dart/completion_manager.dart'
show DartCompletionRequestImpl;
import 'package:analysis_server/src/services/completion/dart_completion_manager.dart'
- show DART_RELEVANCE_DEFAULT, DART_RELEVANCE_LOW;
+ show DART_RELEVANCE_DEFAULT, DART_RELEVANCE_LOW, ReplacementRange;
import 'package:analysis_server/src/services/index/index.dart';
import 'package:analysis_server/src/services/index/local_memory_index.dart';
import 'package:analysis_server/src/services/search/search_engine_internal.dart';
@@ -37,6 +37,8 @@ abstract class DartCompletionContributorTest extends AbstractContextTest {
String testFile = '/completionTest.dart';
Source testSource;
int completionOffset;
+ int replacementOffset;
+ int replacementLength;
DartCompletionContributor contributor;
DartCompletionRequest request;
List<CompletionSuggestion> suggestions;
@@ -149,6 +151,9 @@ abstract class DartCompletionContributorTest extends AbstractContextTest {
CompletionRequestImpl baseRequest = new CompletionRequestImpl(
context, provider, searchEngine, testSource, completionOffset);
request = new DartCompletionRequestImpl.forRequest(baseRequest);
+ var range = new ReplacementRange.compute(request.offset, request.target);
+ replacementOffset = range.offset;
+ replacementLength = range.length;
Completer<List<CompletionSuggestion>> completer =
new Completer<List<CompletionSuggestion>>();

Powered by Google App Engine
This is Rietveld 408576698