Make sure keybindings removed don't come back during extension update.

chrome/browser/extensions/api/commands/command_service.cc

Index: chrome/browser/extensions/api/commands/command_service.cc
diff --git a/chrome/browser/extensions/api/commands/command_service.cc b/chrome/browser/extensions/api/commands/command_service.cc
index 74645d250b5284b050eeadcef1c0f3392b4b79db..dceca5a5841a487d2563bc2bec5ce72a01690836 100644
--- a/chrome/browser/extensions/api/commands/command_service.cc
+++ b/chrome/browser/extensions/api/commands/command_service.cc
@@ -231,6 +231,13 @@ void CommandService::AssignInitialKeybindings(const Extension* extension) {
   if (!commands)
     return;
 
+  ExtensionService* extension_service =
+      ExtensionSystem::Get(profile_)->extension_service();
+  ExtensionPrefs* extension_prefs = extension_service->extension_prefs();
+  if (extension_prefs->InitialBindingsHaveBeenAssigned(extension->id()))

[Yoyo Zhou, 2013/05/06 18:47:58]

We now prefer to have less API-specific knowledge in ExtensionPrefs, so I'd
prefer something like
InitialBindingsHaveBeenAssigned(extension_prefs, extension->id())
and that could go here in an anonymous namespace.

[Finnur, 2013/05/06 23:13:54]

Do you have a CL I can take a look at to see how the latest and greatest truth
should be implemented? :)

[Yoyo Zhou, 2013/05/07 01:21:05]

Sure, there's a good example in

https://codereview.chromium.org/14699002/diff/35001/chrome/browser/extensions...

+    return;
+  extension_prefs->SetInitialBindingsHaveBeenAssigned(extension->id());
+
   extensions::CommandMap::const_iterator iter = commands->begin();
   for (; iter != commands->end(); ++iter) {
     if (!chrome::IsChromeAccelerator(