Make sure keybindings removed don't come back during extension update.

chrome/browser/extensions/api/commands/command_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/commands/command_service.h"
 
 #include "base/lazy_instance.h"
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/extensions/api/commands/commands.h"
@@ skipping 213 matching lines @@
 
   return ui::Accelerator();
 }
 
 void CommandService::AssignInitialKeybindings(const Extension* extension) {
   const extensions::CommandMap* commands =
       CommandsInfo::GetNamedCommands(extension);
   if (!commands)
     return;
 
+  ExtensionService* extension_service =
+      ExtensionSystem::Get(profile_)->extension_service();
+  ExtensionPrefs* extension_prefs = extension_service->extension_prefs();
+  if (extension_prefs->InitialBindingsHaveBeenAssigned(extension->id()))

[Yoyo Zhou, 2013/05/06 18:47:58]

We now prefer to have less API-specific knowledge in ExtensionPrefs, so I'd
prefer something like
InitialBindingsHaveBeenAssigned(extension_prefs, extension->id())
and that could go here in an anonymous namespace.

[Finnur, 2013/05/06 23:13:54]

Do you have a CL I can take a look at to see how the latest and greatest truth
should be implemented? :)

[Yoyo Zhou, 2013/05/07 01:21:05]

Sure, there's a good example in

https://codereview.chromium.org/14699002/diff/35001/chrome/browser/extensions...

+    return;
+  extension_prefs->SetInitialBindingsHaveBeenAssigned(extension->id());
+
   extensions::CommandMap::const_iterator iter = commands->begin();
   for (; iter != commands->end(); ++iter) {
     if (!chrome::IsChromeAccelerator(
         iter->second.accelerator(), profile_)) {
       AddKeybindingPref(iter->second.accelerator(),
                         extension->id(),
                         iter->second.command_name(),
                         false);  // Overwriting not allowed.
     }
   }
@@ skipping 122 matching lines @@
     return false;
 
   *command = *requested_command;
   if (shortcut_assigned.key_code() != ui::VKEY_UNKNOWN)
     command->set_accelerator(shortcut_assigned);
 
   return true;
 }
 
 }  // namespace extensions