Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1498983002: Address clang warning regarding incorrect flag attempting to force non-executable stacks. (Closed)

Created:
5 years ago by rmacnak
Modified:
5 years ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, ricow1
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Address clang warning regarding incorrect flag attempting to force non-executable stacks. Cf. 6d018b8ce3d691f936149bf34f7d584438be146c R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/08f443f54025192e5edced845fb104dbef620264

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tools/gyp/configurations_make.gypi View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
5 years ago (2015-12-03 23:53:13 UTC) #2
Florian Schneider
lgtm
5 years ago (2015-12-04 14:03:43 UTC) #3
rmacnak
5 years ago (2015-12-04 17:58:57 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
08f443f54025192e5edced845fb104dbef620264 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698